Re: [Libguestfs] [PATCH 00/13] syntax-check

Hu Tao
2014-09-24T01:22:16Z

On Tue, Sep 23, 2014 at 04:00:34PM +0200, Pino Toscano
wrote:
> Hi Hu,
>
> On Tuesday 23 September 2014 17:20:26 Hu Tao wrote:
> > This series includes patches to make `make syntax-check` pass.
>
> Thanks for your work. I have few general notes about it:
>
> - please be more descriptive about each issue: just tell in the first
>   line of the commit what is the actual change (like "remove extra
>   getopt.h includes"), mentioning the check name in the long
>   description. This way it is more clear what the change was about, also
>   in case sometime in the future some of those checks is removed.
>
> - in case of unused includes, I'd say it should be fine to just remove
>   them together in a single commit
>
> I'll comment on specific issues in each commit.

Thanks for review! I'm sorry to bring so much noise. I agree with Rich
it's better to remove syntax-check.

Regards,
Hu