Re: [Libguestfs] [PATCH 00/13] syntax-check

Pino Toscano
2014-09-23T14:00:34Z

Hi Hu,

On Tuesday 23 September 2014 17:20:26 Hu Tao wrote:
> This series includes patches to make `make syntax-check` pass.

Thanks for your work. I have few general notes about it:

- please be more descriptive about each issue: just tell in the first
  line of the commit what is the actual change (like "remove extra
  getopt.h includes"), mentioning the check name in the long
  description. This way it is more clear what the change was about, also
  in case sometime in the future some of those checks is removed.

- in case of unused includes, I'd say it should be fine to just remove
  them together in a single commit

I'll comment on specific issues in each commit.

> Some of the fix require change to maint.mk, but the file is not in git
> repo. Is it intended?

This file comes from gnulib (see .gnulib/top/maint.mk), so changes to it
need to go to gnulib (and most probably require FSF copyright
assignment, but I'm not sure about it).

Thanks,
--
Pino Toscano