Re: [Libguestfs] [PATCH 07/13] syntax-check: fix prohibit_empty_lines_at_EOF check

Pino Toscano
2014-09-23T14:00:49Z

On Tuesday 23 September 2014 17:20:33 Hu Tao wrote:
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  builder/website/ubuntu.preseed         | 1 -
>  guestfs-release-notes.txt              | 1 -
>  p2v/issue                              | 1 -
>  tests/guests/guest-aux/debian-packages | 1 -
>  4 files changed, 4 deletions(-)
>
> diff --git a/builder/website/ubuntu.preseed
> b/builder/website/ubuntu.preseed index 236e174..dbe4f79 100644
> --- a/builder/website/ubuntu.preseed
> +++ b/builder/website/ubuntu.preseed
> @@ -373,4 +373,3 @@ xserver-xorg xserver-xorg/config/monitor/mode-list
> \ # directly, or use the apt-install and in-target commands to easily
> install # packages and run commands in the target system.
>  #d-i preseed/late_command string apt-install zsh; in-target chsh -s
> /bin/zsh
> -

This is harmless.

> diff --git a/guestfs-release-notes.txt b/guestfs-release-notes.txt
> index 1baa447..3eada81 100644
> --- a/guestfs-release-notes.txt
> +++ b/guestfs-release-notes.txt
> @@ -3248,4 +3248,3 @@ BUGS
>
>        * Run libguestfs-test-tool(1) and paste the complete, unedited
> output into the bug report.
> -

guestfs-release-notes.txt is generated from guestfs-release-notes.pod.

> diff --git a/p2v/issue b/p2v/issue
> index ae0930f..9b2839e 100644
> --- a/p2v/issue
> +++ b/p2v/issue
> @@ -11,4 +11,3 @@ If virt-p2v didn't start automatically, look for
> logs:
>
>                  systemctl status p2v -l
>  ***
> -

This is installed as /etc/issue in the p2v iso (see
p2v/virt-p2v-make-disk.in). I assume the extra empty line is cosmetic.

> diff --git a/tests/guests/guest-aux/debian-packages
> b/tests/guests/guest-aux/debian-packages index 38afc97..cdd0d27
> 100644
> --- a/tests/guests/guest-aux/debian-packages
> +++ b/tests/guests/guest-aux/debian-packages
> @@ -45,4 +45,3 @@ Description: this is a test package
>   .
>   Don't confuse it with a real package.
>  Homepage: http://libguestfs.org/
> -

No, this is needed, as this file is a fake "status" file for dpkg.

--
Pino Toscano