Re: [Libguestfs] [PATCH 02/13] syntax-check: fix error_message_period check

Richard W.M. Jones
2014-09-23T15:33:07Z

On Tue, Sep 23, 2014 at 05:20:28PM +0800, Hu Tao wrote:
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  resize/resize.ml     | 10 +++++-----
>  sparsify/copying.ml  |  2 +-
>  src/fuse.c           |  2 +-
>  src/launch-libvirt.c |  4 ++--
>  src/libvirt-domain.c |  2 +-
>  v2v/convert_linux.ml |  6 +++---
>  v2v/input_libvirt.ml |  4 ++--
>  v2v/lib_ovf.ml       |  2 +-
>  v2v/output_glance.ml |  2 +-
>  v2v/output_rhev.ml   |  6 +++---
>  v2v/v2v.ml           |  6 +++---
>  11 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/resize/resize.ml b/resize/resize.ml
> index 81bb270..a3ea9be 100644
> --- a/resize/resize.ml
> +++ b/resize/resize.ml
> @@ -310,7 +310,7 @@ read the man page virt-resize(1).
>      let infile >        try (infile, URI.parse_uri infile)
>        with Invalid_argument "URI.parse_uri" ->
> -        error (f_"error parsing URI '%s'. Look for error
messages printed above.")
> +        error (f_"error parsing URI '%s'. Look for error
messages printed above")
>            infile in

Basically make syntax-check is wrong about all of these error
messages, which is why I don't often run it.

It's fine to have a full stop at the end of a new sentence, I think.

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.