Re: [Libguestfs] [PATCH 12/13] syntax-check: fix require_config_h_first check

Pino Toscano
2014-09-23T14:01:01Z

On Tuesday 23 September 2014 17:20:38 Hu Tao wrote:
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  python/guestfs-py-byhand.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/python/guestfs-py-byhand.c b/python/guestfs-py-byhand.c
> index b071f81..5d2d858 100644
> --- a/python/guestfs-py-byhand.c
> +++ b/python/guestfs-py-byhand.c
> @@ -24,11 +24,11 @@
>  /* This has to be included first, else definitions conflict with
>   * glibc header files.  Python is broken.
>   */
> +#include <config.h>
> +
>  #define PY_SSIZE_T_CLEAN 1
>  #include <Python.h>
>
> -#include <config.h>
> -
>  #include <stdio.h>
>  #include <stdlib.h>

This is wrong, and the commit above in that code part tells you why.

--
Pino Toscano