Re: [Libguestfs] [PATCH 1/3] builder: do not use xz --block-size for the test images

Richard W.M. Jones
2014-08-19T14:53:14Z

On Tue, Aug 19, 2014 at 04:01:04PM +0200, Pino Toscano
wrote:
> Do not use the --block-size parameter of xz when compressing the test
> images, as that option does not exist in xz < 5.1.
> ---
>  builder/Makefile.am | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builder/Makefile.am b/builder/Makefile.am
> index 6a5cb01..726ca60 100644
> --- a/builder/Makefile.am
> +++ b/builder/Makefile.am
> @@ -224,12 +224,12 @@ fedora.qcow2: ../tests/guests/fedora.img
>
>  fedora.qcow2.xz: fedora.qcow2
>  	rm -f $@ $@-t
> -	xz --best --block-size=16777216 -c $< > $@-t
> +	xz --best -c $< > $@-t
>  	mv $@-t $@
>
>  %.xz: ../tests/guests/%.img
>  	rm -f $@ $@-t
> -	xz --best --block-size=16777216 -c $< > $@-t
> +	xz --best -c $< > $@-t
>  	mv $@-t $@
>
>  TESTS = \

Hmmm, but OK.

I don't understand the reason why these distros ship ancient
versions of xz TBH ...

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch