Re: [Libguestfs] [PATCH 2/3] tests: make the scratch disk used for scratch much larger

Richard W.M. Jones
2014-08-19T14:55:41Z

On Tue, Aug 19, 2014 at 04:01:05PM +0200, Pino Toscano
wrote:
> 50M can be not enough when uploading various copies of unstripped
> static binaries from the system, which can fill up such a small disk.
> ---
>  generator/actions.ml     | 2 +-
>  tests/c-api/tests-main.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/generator/actions.ml b/generator/actions.ml
> index 9570d9b..245da6f 100644
> --- a/generator/actions.ml
> +++ b/generator/actions.ml
> @@ -9607,7 +9607,7 @@ device is stopped, but it is not destroyed or
zeroed." };
>            "check_hash (ret, \"PART_ENTRY_NUMBER\",
\"1\") == 0 && "^
>            "check_hash (ret, \"PART_ENTRY_TYPE\",
\"0x83\") == 0 && "^
>            "check_hash (ret, \"PART_ENTRY_OFFSET\",
\"128\") == 0 && "^
> -          "check_hash (ret, \"PART_ENTRY_SIZE\",
\"102145\") == 0"), [];
> +          "check_hash (ret, \"PART_ENTRY_SIZE\",
\"1023745\") == 0"), [];
>      ];
>      shortdesc = "print block device attributes";
>      longdesc = "\
> diff --git a/tests/c-api/tests-main.c b/tests/c-api/tests-main.c
> index e2e86f5..e81e15e 100644
> --- a/tests/c-api/tests-main.c
> +++ b/tests/c-api/tests-main.c
> @@ -436,7 +436,7 @@ create_handle (void)
>      exit (EXIT_FAILURE);
>    }
>
> -  if (guestfs_add_drive_scratch (g, 52428800, -1) == -1) {
> +  if (guestfs_add_drive_scratch (g, 524288000, -1) == -1) {
>      printf ("FAIL: guestfs_add_drive_scratch\n");
>      exit (EXIT_FAILURE);
>    }
> --
> 1.9.3

ACK, but please also change the documentation: See src/guestfs.pod
under the section "ADDING TESTS FOR AN API ACTION".

Rich.

--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.