Re: [Libguestfs] [PATCH 0/4] virt-v2v: Convert RedHat.pm to Linux.pm

Matthew Booth
Wed, 06 Nov 2013 16:47:37 -0000

Thanks, Mike. ACK to all of these, and pushed.

As it happens, I'd already started breaking some of this stuff out
myself when I found this patchset :/ Rather than redo it, I've kept what
I'd already done and rebased on top of it.

I also did some testing and fixed a couple of bugs:

"/files$grub->{grub_conf}*/kernel/root" should have been
"/files
$grub->{grub_conf}/*/kernel/root" in _remap_block_devices.

It turns out that the release suffix used by RHEL 4 and 5 really is
'xen', not '-xen'. Note that this is the release, not the
package name,
which is what confused me when I originally reviewed it. I've removed
this change.

Can you please pull the latest from git and rebase any future patches on
top of that? Please be careful not to reintroduce the '-xen' change!
I've accidentally done that at least once whilst working on this
patchset.

Matt

On Thu, 2013-10-31 at 14:14 -0600, Mike Latimer wrote:
> In preparation for an upcoming patch which adds support for SUSE guest
> conversions, it makes sense to have an intermediate steps that changes the
> RedHat.pm converter into a more generic Linux converter. The SUSE changes
> will then be limited in scope to only what is required for SUSE support.
>
> This series of patches accomplishes the following:
>
>  - Renames RedHat.pm to Linux.pm
>  - Modifies Linux.pm to be more generic, and ready for additional
distribution
>    support (such as SUSE)
>  - Adds functionality to _remap_block_devices, to ensure root and resume
>    devices are updated in both grub legacy and grub2 environments
>  - Allows for qxl or cirrus settings in LibVirtTarget.pm (based on passing
>    guestcaps->{display} from the conversion.
>
> I'll submit the SUSE-specific changes after we work through any issues
raised
> here.
>
> Mike Latimer (4):
>   Rename RedHat.pm to Linux.pm
>   Make Linux.pm more generic
>   Handle block remaps in grub and grub2 files
>   Support multiple display types through guestcaps
>
>  MANIFEST                                           |   2 +-
>  lib/Sys/VirtConvert/Connection/LibVirtTarget.pm    |  14 +-
>  .../VirtConvert/Converter/{RedHat.pm => Linux.pm}  | 225
++++++++++++++++-----
>  po/POTFILES.in                                     |   2 +-
>  4 files changed, 185 insertions(+), 58 deletions(-)
>  rename lib/Sys/VirtConvert/Converter/{RedHat.pm => Linux.pm} (92%)
>