Re: [Libguestfs] [PATCH 3/4] Add SUSE converter

Matthew Booth
2013-09-26T09:17:58Z

On Wed, 2013-09-25 at 17:31 +0100, Richard W.M. Jones
wrote:
> On Wed, Sep 25, 2013 at 05:01:56PM +0100, Matthew Booth wrote:
> > Mike,
> >
> > This is great. I have a couple of minor comments inline, but this
looks
> > good.
> >
> > I do have a major concern, though, which is this is basically a fork
of
> > RedHat.pm.
>
> I thought your concern would be that you'd want similar functionality
> in guestconv.  Will this SuSE code need to be rewritten for guestconv?

Yes, it will. However:

* It's still relevant to virt-v2v, which is still in use
* The refactoring exercise will also be relevant to guestconv

Matt