[Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

Daniele Alessandri
Thu, 23 Apr 2009 19:58:35 -0000

Hi,
I just pushed two fixes on my repository, the first one addresses a
bug in Array#rindex (there was a bug in my last commit) and the second
one makes Array#reverse_each compliant with the rubyspecs.

http://github.com/nrk/ironruby/commit/d2b18f5d01a49cb62a2ea0c205e1cf1233ac94e0

>From the commit message:

* Fixed a bug in IListOps.ReverseIndex (core/array/rindex specs were
passing, this bug was triggered under certain conditions different from
the ones defined in the specs)

* Fixed ArrayOps.ReverseEach to make it not fail when elemens in the array
are removed from inside a block.

See also the attached diff.

Thanks,
Daniele

--
Daniele Alessandri
http://www.clorophilla.net/blog/
http://twitter.com/JoL1hAHN
-------------- next part --------------
A non-text attachment was scrubbed...
Name: specs_core_array_090423.diff
Type: application/octet-stream
Size: 3641 bytes
Desc: not available
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20090423/d01b4c3e/attachment.obj>