[Icecast-dev] [PATCH 27/31] connection: more coments for remy

Niv Sardi
Fri, 30 Jul 2010 14:54:49 -0000

src/connection.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/connection.c b/src/connection.c
index 5627933..45a0df9 100644
--- a/src/connection.c
+++ b/src/connection.c
@@ -654,7 +654,8 @@ static void *_connection_thread (void *arg)

         switch (-err) {
         case EAGAIN:     /* put it again at the end of the queue */
-            _add_connection (node);
+            DEBUG1 ("Re-adding connection (%p) on top of queue",
node);
+            _add_connection (node); /* XXX concurency */
             break;
         case EINPROGRESS:	/* already handled */
             free(node);
@@ -777,6 +778,7 @@ static int _connection_process (connection_queue_t *node) {
         return -EINVAL;
     }

+    /* XXX what happens when error in http ??? is err set ? */
     if (httpp_getvar (parser, HTTPP_VAR_ERROR_MESSAGE)) {
         ERROR("Error(%s)", httpp_getvar(parser,
HTTPP_VAR_ERROR_MESSAGE));
         return err;
--
1.7.1