[icecast-dev] Bug in the icecast2 error reporting

Pedro Côrte-Real
2004-08-06T14:57:28Z

On Tue, 19 Nov 2002 00:54:13 +1100
Michael Smith <msmith@xiph.org> wrote:

> At 12:23 PM 18/11/2002 +0000, you wrote:
> >The icecast2 code uses recv(2) to read data from a source and tests
> >its returning value to see if something went wrong. The current code
> >groups together two checks of the return value:
> >
>
> This is a known problem, I just haven't had time to do anything about
> it yet (had my final exam today).
>
> >The patch is a small change but looks longer because I indented the
> >code.
>
> Well... don't do that, then. Patches that do mass reindenting will
> always be rejected, unless there's a REALLY good reason to do so
> (you not liking my indentation style is a very poor reason).

I didn't do a massive reindenting. I reindented just that small part of
the code. I thought it was a mess. Was it supposed to be like that?

> Michael

Pedro.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: part
Type: application/pgp-signature
Size: 190 bytes
Desc: not available