[flac-dev] [PATCH] Updating the ReplayGain documentation

MauritsVB
Mon, 26 Jan 2015 19:55:26 -0000

Apologies, there appears to have been a spacing issue in two of the patches.
Attached are the fixed ones.

Maurits

-------------- next part --------------
A non-text attachment was scrubbed...
Name: main-v2.patch
Type: application/octet-stream
Size: 1656 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20150126/765c1117/attachment.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: metaflac-v2.patch
Type: application/octet-stream
Size: 1039 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20150126/765c1117/attachment-0001.obj
-------------- next part --------------


On 25 Jan 2015, at 01:01, MauritsVB <mauritsvb at xs4all.nl> wrote:

> In this topic on Hydrogen
Audio(http://www.hydrogenaud.io/forums/index.php?showtopic=105586) someone asked
a question about the sample rates that FLAC supports for ReplayGain.
>
> The outcome was that the current documentation of MetaFLAC is outdated
since Commit
http://git.xiph.org/?p=flac.git;a=commit;h=0554a4aee6966bc5b251364753ef85de72dfab19
because as of 1.3.0 FLAC supports Replaygain with many more sample rates. The
changelog suggests it is supported up to 192 kHz, if I apply multiples it should
actually support up to 512 kHz I believe.
>
> Can someone please confirm:
>
> 1) that the commit indeed adds support for multiples. Meaning that MetaFLAC
not only supports 8, 11.025, 12, 16, 18.9, 22.05, 24, 28, 32, 36, 37.8, 44.1, 48
(as explicitly referenced in the commit) but also multiples of those.
>
> 2) that if it supports multiples, my calculations are correct and it
supports the following sample rates: 8, 11.025, 12, 16, 18.9, 22.05, 24, 28, 32,
36, 37.8, 44.1, 48, 56, 64, 72, 75.6, 88.2, 96, 128, 151.2, 176.4, 192, 224,
256, 288, 302.4, 352.8, 384 and 512 kHz.
>
> 3) that main.c and metaflac are the only places where the documentation
needs to be patched.
>
> If that is correct than I suggest to change the documentation to read:
>
> "The sample rate must be one of 8, 11.025, 12, 16, 18.9, 22.05, 24,
28, 32, 36, 37.8, 44.1, 48, 56, 64, 72, 75.6, 88.2, 96, 128, 151.2, 176.4, 192,
224, 256, 288, 302.4, 352.8, 384 or 512 kHz."
>
> Attached are four patches that apply this change:
> website_flac.patch - patches the flac documentation on the website
> website_metaflac.patch - patches the metaflac documentation on the website
> main.patch - patches main to change the documentation in the binary
> metaflac.patch - patches metaflac to change the documentation in the binary
>
> Maurits
>
<website_flac.patch><website_metaflac.patch><main.patch><metaflac.patch>_______________________________________________
> flac-dev mailing list
> flac-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/flac-dev