[flac-dev] [PATCH] Updating the ReplayGain documentation

MauritsVB
Sun, 25 Jan 2015 01:01:48 -0000

In this topic on Hydrogen
Audio(http://www.hydrogenaud.io/forums/index.php?showtopic=105586) someone asked
a question about the sample rates that FLAC supports for ReplayGain.

The outcome was that the current documentation of MetaFLAC is outdated since
Commit
http://git.xiph.org/?p=flac.git;a=commit;h=0554a4aee6966bc5b251364753ef85de72dfab19
because as of 1.3.0 FLAC supports Replaygain with many more sample rates. The
changelog suggests it is supported up to 192 kHz, if I apply multiples it should
actually support up to 512 kHz I believe.

Can someone please confirm:

1) that the commit indeed adds support for multiples. Meaning that MetaFLAC not
only supports 8, 11.025, 12, 16, 18.9, 22.05, 24, 28, 32, 36, 37.8, 44.1, 48 (as
explicitly referenced in the commit) but also multiples of those.

2) that if it supports multiples, my calculations are correct and it supports
the following sample rates: 8, 11.025, 12, 16, 18.9, 22.05, 24, 28, 32, 36,
37.8, 44.1, 48, 56, 64, 72, 75.6, 88.2, 96, 128, 151.2, 176.4, 192, 224, 256,
288, 302.4, 352.8, 384 and 512 kHz.

3) that main.c and metaflac are the only places where the documentation needs to
be patched.

If that is correct than I suggest to change the documentation to read:

"The sample rate must be one of 8, 11.025, 12, 16, 18.9, 22.05, 24, 28, 32,
36, 37.8, 44.1, 48, 56, 64, 72, 75.6, 88.2, 96, 128, 151.2, 176.4, 192, 224,
256, 288, 302.4, 352.8, 384 or 512 kHz."

Attached are four patches that apply this change:
website_flac.patch - patches the flac documentation on the website
website_metaflac.patch - patches the metaflac documentation on the website
main.patch - patches main to change the documentation in the binary
metaflac.patch - patches metaflac to change the documentation in the binary

Maurits
-------------- next part --------------
A non-text attachment was scrubbed...
Name: website_flac.patch
Type: application/octet-stream
Size: 1924 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20150125/9000b295/attachment.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: website_metaflac.patch
Type: application/octet-stream
Size: 1727 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20150125/9000b295/attachment-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: main.patch
Type: application/octet-stream
Size: 1544 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20150125/9000b295/attachment-0002.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: metaflac.patch
Type: application/octet-stream
Size: 1007 bytes
Desc: not available