[flac-dev] flac 1.3.0pre2 pre-release

Erik de Castro Lopo
Mon, 11 Mar 2013 11:05:49 -0000

Janne Hyv?rinen wrote:

> Here's a patch that fixes the creation of larger than 2 GB FLAC files.
> Without this patch both GCC and MSVC compiles of FLAC will fail on
> Windows when they have written 2 GB file while encoding from stdin. And
> after 4GB when encoding from WAV file.

Ok.

> It includes Ben Allison's MSVC changes and JonY's MinGW changes
with
> some tweaks to make both environments happy.

Please don't do that. Adding bits of other patches makes it more
difficult to evaluate and review this patch which is already difficult
to review because of its size.

> And I had to do some more
> inline changing to get my MSVC 2012 to compile the sources.

I would still like to have this problem explained to me.

> There may still be some bug in FLAC's large input wav handling as the
> test FLAC I created by encoding over 22 hours of 24 bit data makes
> foobar2000 report one sample mismatch in reported and decoded length. Or
> it's a rounding bug in foobar2000.

Is it not possible to test this without involving foobar2000?