[flac-dev] flac 1.3.0pre2 pre-release

Erik de Castro Lopo
Mon, 11 Mar 2013 11:27:01 -0000

Ben Allison wrote:

> As mentioned before, this removes some of the 'inline' from the
bitreader
> and bitwriter functions that were used in another translation unit.
I'm
> surprised that this code works on other platform.  It must be a bug in
> GCC, or maybe deliberately non-standard behavior.   See 6.7.4 of the C99
> spec for details.

I've read section 6.7.4 from here:

    http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1124.pdf

My reading of that section suggests that the usage in FLAC is valid and
correct.

As for the addition of safe_malloc_mul_2op_ to file src/share/utf8/utf8.c,
that simply should not be necessary. I suggest this is an error in the
Visual Studio project files.