[Flac-dev] Git branch with compiling fixes for win32

JonY
Tue, 15 Nov 2011 13:28:35 -0000

On 11/14/2011 18:01, JonY wrote:
> On 11/10/2011 19:22, JonY wrote:
>> On 11/10/2011 18:39, Erik de Castro Lopo wrote:
>>>
>>> I'm subscribed to the list (and I set my reply-to to the list).
>>> Please do not CC me.
>>>
>>> JonY wrote:
>>>
>>>> Its probably on one of the sf tracker somewhere, I can't
seem to find it
>>>> anymore. It wasn't anything complicated, so I should be
able to redo it
>>>> quickly.
>>>
>>> I'm a Linux guy. I do not have easy access to a windows machine
>>> and don't have the time or patience to maintain one.
>>>
>>> For windows stuff I'll be relying on others to provide and test
>>> patches.
>>>
>>> Erik
>>
>> Alright, here's a quick fix, although it is more ugly than I
remembered.
>>
>> Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h
>> where available, and falls back to I64 on MSVC and then ll for others,
>> all format warnings suppressed.
>>
>> Tested on MinGW.
>>
>> Sven-Hendrik, or any other mingw guys around, do you mind testing the
>> patch too? Patch based on git master from
>> https://git.xiph.org/mirrors/flac.git.
>>
>
> Ifdef changes now consolidated into a single file.

Ping, no comments?

I noticed some more ifdeferies around that needs consolidating and
warnings that need suppressing, that can go into a separate patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: OpenPGP digital signature