Re: ext3-0.0.5c released

Andreas Dilger
Tue, 12 Dec 2000 23:28:49 -0000

Stephen,
I noticed a couple small bugs in the COMPAT fixes that are in 0.0.5c that
were fixed after I posted my patches.  One is only a warning message that
is printed, but since it mentions e2fsck, people may worry about it.  The
other is also a very rare case - if you are creating a > 2GB file for the
first time on a rev 0 filesystem.

As I write my network is down since last night, so I don't know when this
will get out.  It may have been fixed by you already.

I'm just in the process of seeing what else is different between 2.2.18-ext2
and 0.0.5c ext3 to sync them up again.

Cheers, Andreas
==========================================================================---
linux/fs/ext3/super.c.orig	Tue Dec 12 15:52:23 2000
+++ linux/fs/ext3/super.c	Tue Dec 12 16:00:21 2000
@@ -682,7 +682,7 @@
 		MOD_DEC_USE_COUNT;
 		return NULL;
 	}
-	if (le32_to_cpu(es->s_rev_level) > EXT3_GOOD_OLD_REV &&
+	if (le32_to_cpu(es->s_rev_level) == EXT3_GOOD_OLD_REV &&
 	    (EXT3_HAS_COMPAT_FEATURE(sb, ~0U) ||
 	     EXT3_HAS_RO_COMPAT_FEATURE(sb, ~0U) ||
 	     EXT3_HAS_INCOMPAT_FEATURE(sb, ~0U)))
--- linux/fs/ext3/file.c.orig	Tue Dec 12 15:52:23 2000
+++ linux/fs/ext3/file.c	Tue Dec 12 16:00:21 2000
@@ -270,6 +270,7 @@
 			/* If this is the first large file created, add a flag
 			   to the superblock */
 			journal_get_write_access(handle, sb->u.ext3_sb.s_sbh);
+			ext3_update_fs_rev(sb);
 			EXT3_SET_RO_COMPAT_FEATURE(sb,
 					EXT3_FEATURE_RO_COMPAT_LARGE_FILE);
 			journal_dirty_metadata(handle, sb->u.ext3_sb.s_sbh);

--
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert