dovecot - Feb 2008 - GETSCRIPT Bug in dovecot-1.0.10-MANAGESIEVE-v9.1.diff.gz

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Stephan,

GETSCRIPT does not return a literal, there is the + character missing 
before }:

diff -r bcebda39c0ed src/managesieve/cmd-getscript.c
- --- a/src/managesieve/cmd-getscript.c   Mon Feb 18 14:13:12 2008 +0100
+++ b/src/managesieve/cmd-getscript.c   Fri Feb 29 11:52:00 2008 +0100
@@ -112,7 +112,7 @@
                 return cmd_getscript_finish(ctx);
         }

- -       client_send_line(client,
t_strdup_printf("{%"PRIuUOFF_T"}",
ctx->scriptsize));
+       client_send_line(client,
t_strdup_printf("{%"PRIuUOFF_T"+}",
ctx->scriptsize));

         client->command_pending = TRUE;
         cmd->func = cmd_getscript_continue;

Bye,

- -- 
Steffen Kaiser
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHx/5aVJMDrex4hCIRAkVLAKDRtWkG5fkLi4XmsYmoSktLGL7IxACfUhNt
UwvPeQokHV5nvELkXPMfrjg=8EhM
-----END PGP SIGNATURE-----

Hi Steffen,

Steffen Kaiser schreef:
> diff -r bcebda39c0ed src/managesieve/cmd-getscript.c
> - --- a/src/managesieve/cmd-getscript.c   Mon Feb 18 14:13:12 2008 +0100
> +++ b/src/managesieve/cmd-getscript.c   Fri Feb 29 11:52:00 2008 +0100
> @@ -112,7 +112,7 @@
>                 return cmd_getscript_finish(ctx);
>         }
>
> - -       client_send_line(client,
t_strdup_printf("{%"PRIuUOFF_T"}",
> ctx->scriptsize));
> +       client_send_line(client,
t_strdup_printf("{%"PRIuUOFF_T"+}",
> ctx->scriptsize));
>
>         client->command_pending = TRUE;
>         cmd->func = cmd_getscript_continue;
I've had a discussion about this issue with one of the editors of the 
ManageSieve specification. The current CMU implementation also doesn't 
send a + before } in a string literal towards the client and there are 
currently quite a few clients that depend on that behavior (which broke 
with one of my older versions). That is why he decided to change the 
specification to match CMU. In version 08 of the specification he has 
posted a TODO comment in the ABNF below the literal specification, 
indicating that he still has to change it. I didn't see a new 
specification yet, but I already changed the server to match that behavior.

All clients I know have no problem with this as they are tested against 
CMU ManageSieve. How did you encounter this? Are you writing your own 
client or did you find one that breaks?

I think I'll poke him again for any progress on this issue. A new draft 
is due anyway :)

Regards,

Stephan.