Btrfs devel - Jun 2013 - [PATCH] btrfs-progs: btrfs requires version.h

$ make btrfs
    [CC]     ctree.o
    [CC]     disk-io.o
    [CC]     radix-tree.o
    [CC]     extent-tree.o
    [CC]     print-tree.o
    [CC]     root-tree.o
    [CC]     dir-item.o
    [CC]     file-item.o
    [CC]     inode-item.o
    [CC]     inode-map.o
    [CC]     extent-cache.o
    [CC]     extent_io.o
    [CC]     volumes.o
    [CC]     utils.o
    [CC]     repair.o
    [CC]     qgroup.o
    [CC]     raid6.o
    [CC]     free-space-cache.o
    [CC]     btrfs.o
btrfs.c:24:21: fatal error: version.h: No such file or directory
 #include "version.h"
                     ^
compilation terminated.
make: *** [btrfs.o] Error 1

Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index da7438e..0bca4d7 100644
--- a/Makefile
+++ b/Makefile
@@ -131,7 +131,7 @@ btrfs-%: version.h $(objects) $(libs) btrfs-%.o
 	@echo "    [LD]     $@"
 	$(Q)$(CC) $(CFLAGS) -o $@ $(objects) $@.o $(LDFLAGS) $(LIBS) $($(subst
-,_,$@-libs))
 
-btrfs: $(objects) btrfs.o help.o $(cmds_objects) $(libs)
+btrfs: version.h $(objects) btrfs.o help.o $(cmds_objects) $(libs)
 	@echo "    [LD]     $@"
 	$(Q)$(CC) $(CFLAGS) -o btrfs btrfs.o help.o $(cmds_objects) \
 		$(objects) $(LDFLAGS) $(LIBS) -lpthread
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Sat, Jun 22, 2013 at 03:13:42PM +0900, Kusanagi Kouichi
wrote:
> $ make btrfs
...
>     [CC]     btrfs.o
> btrfs.c:24:21: fatal error: version.h: No such file or directory
>  #include "version.h"
Not only the ''btrfs'' target, but also mkfs.btrfs (both dynamic
and
static) and the other targets that include version.h and are not covered
by the generic rules.

I''d rather see the dependency added for all of them in one patch.

thanks,
david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html