Wei Yongjun
2013-May-21 02:39 UTC
[PATCH -next] Btrfs: return error code in btrfs_check_trunc_cache_free_space()
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Fix to return error code instead always return 0 from function btrfs_check_trunc_cache_free_space(). Introduced by commit 7b61cd92242542944fc27024900c495a6a7b3396 (Btrfs: don''t use global block reservation for inode cache truncation) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> --- fs/btrfs/free-space-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index e530096..73577f4 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c @@ -213,7 +213,7 @@ int btrfs_check_trunc_cache_free_space(struct btrfs_root *root, else ret = 0; spin_unlock(&rsv->lock); - return 0; + return ret; } int btrfs_truncate_free_space_cache(struct btrfs_root *root, -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Miao Xie
2013-May-22 01:35 UTC
Re: [PATCH -next] Btrfs: return error code in btrfs_check_trunc_cache_free_space()
On Tue, 21 May 2013 10:39:21 +0800, Wei Yongjun wrote:> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fix to return error code instead always return 0 from function > btrfs_check_trunc_cache_free_space(). > Introduced by commit 7b61cd92242542944fc27024900c495a6a7b3396 > (Btrfs: don''t use global block reservation for inode cache truncation) > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>Thanks for your fix. Reviewed-by: Miao Xie <miaox@cn.fujitsu.com>> --- > fs/btrfs/free-space-cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c > index e530096..73577f4 100644 > --- a/fs/btrfs/free-space-cache.c > +++ b/fs/btrfs/free-space-cache.c > @@ -213,7 +213,7 @@ int btrfs_check_trunc_cache_free_space(struct btrfs_root *root, > else > ret = 0; > spin_unlock(&rsv->lock); > - return 0; > + return ret; > } > > int btrfs_truncate_free_space_cache(struct btrfs_root *root, > >-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html