Richard W.M. Jones
2013-May-12 15:33 UTC
[PATCH 0/0] libbtrfs: Set SONAME to "libbtrfs.so.0" (instead of "libbtrfs.so")
In the original version of "btrfs-progs: libify some parts of btrfs-progs" by Mark Fasheh, the soname field of the internal libbtrfs library was set to "libbtrfs.so.1". This doesn''t match the filename of the library (libbtrfs.so.0.1) which is unusual. However in the version which went upstream, the soname was changed to just "libbtrfs.so". There doesn''t seem to be any mention of why this was changed. This soname doesn''t follow the normal convention, and confuses some tools that we use in Fedora to handle shared libraries. This patch changes the soname to "libbtrfs.so.0" to match the filename and the usual convention for sonames. It would also allow a future version of this library to make breaking ABI changes by changing the soname (eg. to "libbtrfs.so.1"), but allowing callers to use either the old or the new version. Rich. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Richard W.M. Jones
2013-May-12 15:33 UTC
[PATCH] libbtrfs: Set SONAME to "libbtrfs.so.0" (instead of "libbtrfs.so").
From: "Richard W.M. Jones" <rjones@redhat.com> Signed-off-by: Richard W.M. Jones <rjones@redhat.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9c195b3..d2c2e28 100644 --- a/Makefile +++ b/Makefile @@ -93,7 +93,7 @@ version.h: $(libs_shared): $(libbtrfs_objects) $(lib_links) send.h @echo " [LD] $@" - $(Q)$(CC) $(CFLAGS) $(libbtrfs_objects) $(lib_LIBS) -shared -Wl,-soname,libbtrfs.so -o libbtrfs.so.0.1 + $(Q)$(CC) $(CFLAGS) $(libbtrfs_objects) $(lib_LIBS) -shared -Wl,-soname,libbtrfs.so.0 -o libbtrfs.so.0.1 $(libs_static): $(libbtrfs_objects) @echo " [AR] $@" -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David Sterba
2013-May-13 15:19 UTC
Re: [PATCH 0/0] libbtrfs: Set SONAME to "libbtrfs.so.0" (instead of "libbtrfs.so")
On Sun, May 12, 2013 at 04:33:43PM +0100, Richard W.M. Jones wrote:> In the original version of "btrfs-progs: libify some parts of > btrfs-progs" by Mark Fasheh, the soname field of the internal libbtrfs > library was set to "libbtrfs.so.1". This doesn''t match the filename > of the library (libbtrfs.so.0.1) which is unusual.I''ve reworked the lib versions after I got warnings from post-rpm-build checks. The missing .0 in soname is a bug , thanks for the fix. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html