Benno Lossin
2025-Jul-09 20:18 UTC
[PATCH 7/9] rust: pin-init: use `kernel::{fmt,prelude::fmt!}`
On Wed Jul 9, 2025 at 10:00 PM CEST, Tamir Duberstein wrote:> Reduce coupling to implementation details of the formatting machinery by > avoiding direct use for `core`'s formatting traits and macros. > > Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org> > Reviewed-by: Alice Ryhl <aliceryhl at google.com> > Signed-off-by: Tamir Duberstein <tamird at gmail.com> > --- > rust/kernel/init.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)I usually prefix patches to init.rs with `rust: init`. I'll fix it up when picking the patch or Miguel can do it if he takes it: Acked-by: Benno Lossin <lossin at kernel.org> --- Cheers, Benno
Tamir Duberstein
2025-Jul-09 21:02 UTC
[PATCH 7/9] rust: pin-init: use `kernel::{fmt,prelude::fmt!}`
On Wed, Jul 9, 2025 at 4:18?PM Benno Lossin <lossin at kernel.org> wrote:> > On Wed Jul 9, 2025 at 10:00 PM CEST, Tamir Duberstein wrote: > > Reduce coupling to implementation details of the formatting machinery by > > avoiding direct use for `core`'s formatting traits and macros. > > > > Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org> > > Reviewed-by: Alice Ryhl <aliceryhl at google.com> > > Signed-off-by: Tamir Duberstein <tamird at gmail.com> > > --- > > rust/kernel/init.rs | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > I usually prefix patches to init.rs with `rust: init`. I'll fix it up > when picking the patch or Miguel can do it if he takes it: > > Acked-by: Benno Lossin <lossin at kernel.org>Actually, squinting at this patch more closely now, I think this isn't what you had in mind. The comment says "Dummy error that can be constructed outside the `kernel` crate." but the error now comes from the kernel crate :( Perhaps you could suggest a different modification that would both meet the original intent and allow references to core::fmt to disappear?
Benno Lossin
2025-Jul-09 21:58 UTC
[PATCH 7/9] rust: pin-init: use `kernel::{fmt,prelude::fmt!}`
On Wed Jul 9, 2025 at 11:01 PM CEST, Tamir Duberstein wrote:> On Wed, Jul 9, 2025 at 4:18?PM Benno Lossin <lossin at kernel.org> wrote: >> >> On Wed Jul 9, 2025 at 10:00 PM CEST, Tamir Duberstein wrote: >> > Reduce coupling to implementation details of the formatting machinery by >> > avoiding direct use for `core`'s formatting traits and macros. >> > >> > Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org> >> > Reviewed-by: Alice Ryhl <aliceryhl at google.com> >> > Signed-off-by: Tamir Duberstein <tamird at gmail.com> >> > --- >> > rust/kernel/init.rs | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> >> I usually prefix patches to init.rs with `rust: init`. I'll fix it up >> when picking the patch or Miguel can do it if he takes it: >> >> Acked-by: Benno Lossin <lossin at kernel.org> > > Actually, squinting at this patch more closely now, I think this isn't > what you had in mind. The comment says "Dummy error that can be > constructed outside the `kernel` crate." but the error now comes from > the kernel crate :(It's a re-export, so the comment still holds.> Perhaps you could suggest a different modification that would both > meet the original intent and allow references to core::fmt to > disappear?The code comes from a time when `Error::from_errno` was `pub(crate)`, but that was changed some time ago... Now we can just remove the `FromErrno` trait entirely from that example. Feel free to do that in this series or as a standalone patch. --- Cheers, Benno