Nouveau - Jul 2025 - [PATCH v13 2/5] rust: support formatting of foreign types

On Thu, Jul 3, 2025 at 12:26?PM Miguel Ojeda
<miguel.ojeda.sandonis at gmail.com> wrote:
>
> On Thu, Jul 3, 2025 at 3:56?PM Tamir Duberstein <tamird at gmail.com>
wrote:
> >
> > Can you help me understand why? The changes you ask to be separated
> > would all be in different files, so why would separate commits make it
> > easier to review?
>
> By the way, if we are talking about splitting, it is easier to land
> patches that can go independently into different subsystems and
> avoiding flag day changes (or making those as small as possible), i.e.
> ideally being able to land big changes across more than one kernel
> cycle.
Understood, though in this case I don't see how it's workable. The
formatting macros can either wrap in fmt::Adapter (and thus require
kernel::fmt::Display) or not (and thus require core::fmt::Display),
but I don't see how they can work in a mixed world. We can't have half
the subsystems implement core::fmt::Display and the other half
implement kernel::fmt::Display.