Alexandre Courbot
2025-Sep-29 14:45 UTC
[PATCH v2 05/10] gpu: nova-core: gsp: Add GSP command queue handling
On Mon Sep 29, 2025 at 11:38 PM JST, Miguel Ojeda wrote:> On Mon, Sep 29, 2025 at 4:34?PM Alexandre Courbot <acourbot at nvidia.com> wrote: >> >> I think you will also need to explicitly enable the feature somewhere - >> for the kernel crate it is in `rust/kernel/lib.rs`, but Nova being a >> different crate I am not sure where we are supposed to do it... > > `rust_allowed_features` in `scripts/Makefile.build`.Ah, that's where it was! Thanks a lot!
Alistair Popple
2025-Sep-30 11:41 UTC
[PATCH v2 05/10] gpu: nova-core: gsp: Add GSP command queue handling
On 2025-09-30 at 00:45 +1000, Alexandre Courbot <acourbot at nvidia.com> wrote...> On Mon Sep 29, 2025 at 11:38 PM JST, Miguel Ojeda wrote: > > On Mon, Sep 29, 2025 at 4:34?PM Alexandre Courbot <acourbot at nvidia.com> wrote: > >> > >> I think you will also need to explicitly enable the feature somewhere - > >> for the kernel crate it is in `rust/kernel/lib.rs`, but Nova being a > >> different crate I am not sure where we are supposed to do it... > > > > `rust_allowed_features` in `scripts/Makefile.build`. > > Ah, that's where it was! Thanks a lot!Thanks. Is it still expected that `#[allow(clippy::incompatible_msrv)]` is required? Just adding it to `rust_allowed_features` doesn't make the warning go away without the allow, but maybe I'm just doing something wrong...