Viresh Kumar
2025-Jul-21 07:37 UTC
[PATCH 1/6] rust: kernel: remove `fmt!`, fix clippy::uninlined-format-args
On 04-07-25, 16:14, Tamir Duberstein wrote:> Rather than export a macro that delegates to `core::format_args`, simply > re-export `core::format_args` as `fmt` from the prelude. This exposes > clippy warnings which were previously obscured by this macro, such as: > > warning: variables can be used directly in the `format!` string > --> ../drivers/cpufreq/rcpufreq_dt.rs:21:43 > | > 21 | let prop_name = CString::try_from_fmt(fmt!("{}-supply", name)).ok()?; > | ^^^^^^^^^^^^^^^^^^^^^^^ > | > = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args > = note: `-W clippy::uninlined-format-args` implied by `-W clippy::all` > = help: to override `-W clippy::all` add `#[allow(clippy::uninlined_format_args)]` > help: change this to > | > 21 - let prop_name = CString::try_from_fmt(fmt!("{}-supply", name)).ok()?; > 21 + let prop_name = CString::try_from_fmt(fmt!("{name}-supply")).ok()?; > | > > Thus fix them in the same commit. This could possibly be fixed in two > stages, but the diff is small enough (outside of kernel/str.rs) that I > hope it can taken in a single commit. > > Signed-off-by: Tamir Duberstein <tamird at gmail.com> > --- > drivers/cpufreq/rcpufreq_dt.rs | 3 +-- > rust/kernel/opp.rs | 2 +-Acked-by: Viresh Kumar <viresh.kumar at linaro.org> -- viresh