struct nouveau_channel contains the member 'accel_done' and a forgotten
TODO which hints at that mechanism being removed in the "near future".
Since that variable is read nowhere anymore, this "near future" is
now.
Remove the variable and the TODO.
Signed-off-by: Philipp Stanner <phasta at kernel.org>
---
drivers/gpu/drm/nouveau/nouveau_chan.h | 2 --
drivers/gpu/drm/nouveau/nouveau_dma.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.h
b/drivers/gpu/drm/nouveau/nouveau_chan.h
index 561877725aac..bb34b0a6082d 100644
--- a/drivers/gpu/drm/nouveau/nouveau_chan.h
+++ b/drivers/gpu/drm/nouveau/nouveau_chan.h
@@ -31,8 +31,6 @@ struct nouveau_channel {
u64 addr;
} push;
- /* TODO: this will be reworked in the near future */
- bool accel_done;
void *fence;
struct {
int max;
diff --git a/drivers/gpu/drm/nouveau/nouveau_dma.h
b/drivers/gpu/drm/nouveau/nouveau_dma.h
index 0e27b76d1e1c..c25ef9a54b9f 100644
--- a/drivers/gpu/drm/nouveau/nouveau_dma.h
+++ b/drivers/gpu/drm/nouveau/nouveau_dma.h
@@ -90,7 +90,6 @@ FIRE_RING(struct nouveau_channel *chan)
{
if (chan->dma.cur == chan->dma.put)
return;
- chan->accel_done = true;
WRITE_PUT(chan->dma.cur);
--
2.49.0
Does mean that the TODO has been done, or that someone completely forgot and now your patch is remove all reminders? If it's the format, maybe add a fixes: tag for the commit that resolved the TODO? On Fri, 2025-08-01 at 09:45 +0200, Philipp Stanner wrote:> struct nouveau_channel contains the member 'accel_done' and a forgotten > TODO which hints at that mechanism being removed in the "near future". > Since that variable is read nowhere anymore, this "near future" is now. > > Remove the variable and the TODO. > > Signed-off-by: Philipp Stanner <phasta at kernel.org> > --- > ?drivers/gpu/drm/nouveau/nouveau_chan.h | 2 -- > ?drivers/gpu/drm/nouveau/nouveau_dma.h? | 1 - > ?2 files changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_chan.h b/drivers/gpu/drm/nouveau/nouveau_chan.h > index 561877725aac..bb34b0a6082d 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_chan.h > +++ b/drivers/gpu/drm/nouveau/nouveau_chan.h > @@ -31,8 +31,6 @@ struct nouveau_channel { > ? u64 addr; > ? } push; > ? > - /* TODO: this will be reworked in the near future */ > - bool accel_done; > ? void *fence; > ? struct { > ? int max; > diff --git a/drivers/gpu/drm/nouveau/nouveau_dma.h b/drivers/gpu/drm/nouveau/nouveau_dma.h > index 0e27b76d1e1c..c25ef9a54b9f 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_dma.h > +++ b/drivers/gpu/drm/nouveau/nouveau_dma.h > @@ -90,7 +90,6 @@ FIRE_RING(struct nouveau_channel *chan) > ?{ > ? if (chan->dma.cur == chan->dma.put) > ? return; > - chan->accel_done = true; > ? > ? WRITE_PUT(chan->dma.cur); > ?
On 8/1/25 9:45 AM, Philipp Stanner wrote:> struct nouveau_channel contains the member 'accel_done' and a forgotten > TODO which hints at that mechanism being removed in the "near future". > Since that variable is read nowhere anymore, this "near future" is now. > > Remove the variable and the TODO. > > Signed-off-by: Philipp Stanner <phasta at kernel.org>Applied to drm-misc-next, thanks!