Dave Airlie
2024-Mar-14 01:45 UTC
[PATCH] nouveau/gsp: don't check devinit disable on GSP.
From: Dave Airlie <airlied at redhat.com> GSP should be handling this and I can see no evidence in opengpu driver that this register should be touched. Fixed acceleration on 2080 Ti GPUs. Fixes: 15740541e8f0 ("drm/nouveau/devinit/tu102-: prepare for GSP-RM") Signed-off-by: Dave Airlie <airlied at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c index 666eb93b1742..11b4c9c274a1 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c @@ -41,7 +41,6 @@ r535_devinit_new(const struct nvkm_devinit_func *hw, rm->dtor = r535_devinit_dtor; rm->post = hw->post; - rm->disable = hw->disable; ret = nv50_devinit_new_(rm, device, type, inst, pdevinit); if (ret) -- 2.43.2
Timothy Maden
2024-Mar-19 17:38 UTC
[PATCH] nouveau/gsp: don't check devinit disable on GSP.
Hello Can this be merged please ? On 3/14/24 03:45, Dave Airlie wrote:> From: Dave Airlie <airlied at redhat.com> > > GSP should be handling this and I can see no evidence in opengpu > driver that this register should be touched. > > Fixed acceleration on 2080 Ti GPUs. > > Fixes: 15740541e8f0 ("drm/nouveau/devinit/tu102-: prepare for GSP-RM") > > Signed-off-by: Dave Airlie <airlied at redhat.com> > --- > drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c > index 666eb93b1742..11b4c9c274a1 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c > @@ -41,7 +41,6 @@ r535_devinit_new(const struct nvkm_devinit_func *hw, > > rm->dtor = r535_devinit_dtor; > rm->post = hw->post; > - rm->disable = hw->disable; > > ret = nv50_devinit_new_(rm, device, type, inst, pdevinit); > if (ret)
Seemingly Similar Threads
- [PATCH] nouveau/gsp/r535: Fix a NULL vs error pointer bug
- [PATCH] nouveau/gsp: drop the gsp failure message to a debug.
- [bug report] drm/nouveau/gsp/r535: add support for booting GSP-RM
- [PATCH 07/11] nouveau/gsp: convert gsp errors to generic errors
- [PATCH] nouveau/gsp: Avoid addressing beyond end of rpc->entries