Michael S. Tsirkin
2023-Oct-26 15:06 UTC
[PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices
On Thu, Oct 26, 2023 at 01:28:18PM +0000, Parav Pandit wrote:> > > From: Michael S. Tsirkin <mst at redhat.com> > > Sent: Thursday, October 26, 2023 6:45 PM > > > > Followed by an open coded driver check for 0x1000 to 0x103f range. > > > Do you mean windows driver expects specific subsystem vendor id of 0x1af4? > > > > Look it up, it's open source. > > Those are not OS inbox drivers anyway. > :)Does not matter at all if guest has drivers installed. Either you worry about legacy guests or not.> The current vfio driver is following the virtio spec based on legacy spec, 1.x spec following the transitional device sections. > There is no need to do something out of spec at this point.legacy spec wasn't maintained properly, drivers diverged sometimes significantly. what matters is installed base. -- MST
Parav Pandit
2023-Oct-26 15:09 UTC
[PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices
> From: Michael S. Tsirkin <mst at redhat.com> > Sent: Thursday, October 26, 2023 8:36 PM > > On Thu, Oct 26, 2023 at 01:28:18PM +0000, Parav Pandit wrote: > > > > > From: Michael S. Tsirkin <mst at redhat.com> > > > Sent: Thursday, October 26, 2023 6:45 PM > > > > > > Followed by an open coded driver check for 0x1000 to 0x103f range. > > > > Do you mean windows driver expects specific subsystem vendor id of > 0x1af4? > > > > > > Look it up, it's open source. > > > > Those are not OS inbox drivers anyway. > > :) > > Does not matter at all if guest has drivers installed. > Either you worry about legacy guests or not. >So, Linux guests have inbox drivers, that we care about and they seems to be covered, right?> > > The current vfio driver is following the virtio spec based on legacy spec, 1.x > spec following the transitional device sections. > > There is no need to do something out of spec at this point. > > legacy spec wasn't maintained properly, drivers diverged sometimes > significantly. what matters is installed base.So if you know the subsystem vendor id that Windows expects, please share, so we can avoid playing puzzle game. :) It anyway can be reported by the device itself.