Peter Zijlstra
2023-Oct-16 14:29 UTC
[PATCH v2 3/4] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2
On Mon, Oct 16, 2023 at 02:39:32PM +0200, Juergen Gross wrote:> Instead of stacking alternative and paravirt patching, use the new > ALT_FLAG_CALL flag to switch those mixed calls to pure alternative > handling. > > This eliminates the need to be careful regarding the sequence of > alternative and paravirt patching. > > For call depth tracking callthunks_setup() needs to be adapted to patch > calls at alternative patching sites instead of paravirt calls. > > Signed-off-by: Juergen Gross <jgross at suse.com>I cannot help but feel this would've been better as two patches, one introducing ALT_NOT_XEN and then a second with the rest. Regardless, Acked-by: Peter Zijlstra (Intel) <peterz at infradead.org>
Juergen Gross
2023-Oct-16 14:40 UTC
[PATCH v2 3/4] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2
On 16.10.23 16:29, Peter Zijlstra wrote:> On Mon, Oct 16, 2023 at 02:39:32PM +0200, Juergen Gross wrote: >> Instead of stacking alternative and paravirt patching, use the new >> ALT_FLAG_CALL flag to switch those mixed calls to pure alternative >> handling. >> >> This eliminates the need to be careful regarding the sequence of >> alternative and paravirt patching. >> >> For call depth tracking callthunks_setup() needs to be adapted to patch >> calls at alternative patching sites instead of paravirt calls. >> >> Signed-off-by: Juergen Gross <jgross at suse.com> > > I cannot help but feel this would've been better as two patches, one > introducing ALT_NOT_XEN and then a second with the rest.In case I need to respin I'll split it up.> > Regardless, > > Acked-by: Peter Zijlstra (Intel) <peterz at infradead.org>Thanks, Juergen -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_0xB0DE9DD628BF132F.asc Type: application/pgp-keys Size: 3098 bytes Desc: OpenPGP public key URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20231016/23f27527/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_signature.asc Type: application/pgp-signature Size: 495 bytes Desc: OpenPGP digital signature URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20231016/23f27527/attachment.sig>