openssh unix dev - Jun 2023 - openssh portable on FreeBSD i386

On Thu, 1 Jun 2023, mike tancsa wrote:
> Not sure if this is the right approach / patch, but I am able to compile 
No, I?d rather convert the known value to the type-of-unknown-signedness
(might even be float).

-?????????????????????????? now >= c->lastused + c->inactive_deadline)
{
+?????????????????????????? now >= c->lastused +
(time_t)c->inactive_deadline) {

In general, #ifdef i386 is wrong.

bye,
//mirabilos
-- 
Infrastrukturexperte ? tarent solutions GmbH
Am Dickobskreuz 10, D-53121 Bonn ? http://www.tarent.de/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 5168 ? USt-ID (VAT): DE122264941
Gesch?ftsf?hrer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg

                        ****************************************************
/?\ The UTF-8 Ribbon
??? Campaign against      Mit dem tarent-Newsletter nichts mehr verpassen:
??? HTML eMail! Also,     https://www.tarent.de/newsletter
??? header encryption!
                        ****************************************************

On 6/1/2023 11:47 AM, Thorsten Glaser wrote:
> On Thu, 1 Jun 2023, mike tancsa wrote:
>
>> Not sure if this is the right approach / patch, but I am able to
compile
> No, I?d rather convert the known value to the type-of-unknown-signedness
> (might even be float).
>
> -?????????????????????????? now >= c->lastused +
c->inactive_deadline) {
> +?????????????????????????? now >= c->lastused +
(time_t)c->inactive_deadline) {
>
> In general, #ifdef i386 is wrong.
Thanks,

compile/build and run tested on FreeBSD 13 both i386 and AMD64 with the 
following patch

--- channels.c.orig???? 2023-06-01 15:52:19 UTC
+++ channels.c
@@ -2566,7 +2566,7 @@ channel_handler(struct ssh *ssh, int table, struct tim
 ??????????????????????? if (table == CHAN_PRE &&
 ??????????????????????????? c->type == SSH_CHANNEL_OPEN &&
 ??????????????????????????? c->inactive_deadline != 0 &&
c->lastused !=
0 &&
-?????????????????????????? now >= c->lastused + c->inactive_deadline)
{
+?????????????????????????? now >= c->lastused + (time_t) 
c->inactive_deadline) {
 ??????????????????????????????? /* channel closed for inactivity */
 ??????????????????????????????? verbose("channel %d: closing after %u 
seconds "
 ??????????????????????????????????? "of inactivity", c->self,

 ??? ---Mike