Andrew picked ocfs2 patches into -mm tree before. Thanks, Joseph On 4/18/23 5:17 PM, Christian Brauner wrote:> > On Mon, 17 Apr 2023 22:56:24 +0200, Arnd Bergmann wrote: >> On 32-bit architectures with KASAN_STACK enabled, the total stack usage >> of the ocfs2_ioctl function grows beyond the warning limit: >> >> fs/ocfs2/ioctl.c: In function 'ocfs2_ioctl': >> fs/ocfs2/ioctl.c:934:1: error: the frame size of 1448 bytes is larger than 1400 bytes [-Werror=frame-larger-than=] >> >> Move each of the variables into a basic block, and mark ocfs2_info_handle() >> as noinline_for_stack, in order to have the variable share stack slots. >> >> [...] > > Going by git log, ocfs2 patches don't go through a separate tree. > So unless there are objections I'm taking this through fs.misc, > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git > branch: fs.misc > [1/1] ocfs2: reduce ioctl stack usage > commit: 85ef56bc2d65215f43ceb7377ca14a779468928d > > Christian
Christian Brauner
2023-Apr-18 12:56 UTC
[Ocfs2-devel] [PATCH] ocfs2: reduce ioctl stack usage
On Tue, Apr 18, 2023 at 05:37:06PM +0800, Joseph Qi wrote:> Andrew picked ocfs2 patches into -mm tree before.Yup and that's fine obviously, but this belongs to fs/ and we're aiming to take fs/ stuff through the dedicated fs trees going forward. Thanks! Christian> > Thanks, > Joseph > > On 4/18/23 5:17 PM, Christian Brauner wrote: > > > > On Mon, 17 Apr 2023 22:56:24 +0200, Arnd Bergmann wrote: > >> On 32-bit architectures with KASAN_STACK enabled, the total stack usage > >> of the ocfs2_ioctl function grows beyond the warning limit: > >> > >> fs/ocfs2/ioctl.c: In function 'ocfs2_ioctl': > >> fs/ocfs2/ioctl.c:934:1: error: the frame size of 1448 bytes is larger than 1400 bytes [-Werror=frame-larger-than=] > >> > >> Move each of the variables into a basic block, and mark ocfs2_info_handle() > >> as noinline_for_stack, in order to have the variable share stack slots. > >> > >> [...] > > > > Going by git log, ocfs2 patches don't go through a separate tree. > > So unless there are objections I'm taking this through fs.misc, > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping.git > > branch: fs.misc > > [1/1] ocfs2: reduce ioctl stack usage > > commit: 85ef56bc2d65215f43ceb7377ca14a779468928d > > > > Christian