Krzysztof Kozlowski
2023-Apr-07 15:00 UTC
[Nouveau] [PATCH 1/2] drm/i915: constify pointers to hwmon_channel_info
Statically allocated array of pointed to hwmon_channel_info can be made const for safety. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> --- This depends on hwmon core patch: https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski at linaro.org/ Therefore I propose this should also go via hwmon tree. Cc: Jean Delvare <jdelvare at suse.com> Cc: Guenter Roeck <linux at roeck-us.net> Cc: linux-hwmon at vger.kernel.org --- drivers/gpu/drm/i915/i915_hwmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_hwmon.c b/drivers/gpu/drm/i915/i915_hwmon.c index 596dd2c07010..87b527a54272 100644 --- a/drivers/gpu/drm/i915/i915_hwmon.c +++ b/drivers/gpu/drm/i915/i915_hwmon.c @@ -267,7 +267,7 @@ static const struct attribute_group *hwm_groups[] = { NULL }; -static const struct hwmon_channel_info *hwm_info[] = { +static const struct hwmon_channel_info * const hwm_info[] = { HWMON_CHANNEL_INFO(in, HWMON_I_INPUT), HWMON_CHANNEL_INFO(power, HWMON_P_MAX | HWMON_P_RATED_MAX | HWMON_P_CRIT), HWMON_CHANNEL_INFO(energy, HWMON_E_INPUT), @@ -275,7 +275,7 @@ static const struct hwmon_channel_info *hwm_info[] = { NULL }; -static const struct hwmon_channel_info *hwm_gt_info[] = { +static const struct hwmon_channel_info * const hwm_gt_info[] = { HWMON_CHANNEL_INFO(energy, HWMON_E_INPUT), NULL }; -- 2.34.1
Krzysztof Kozlowski
2023-Apr-07 15:00 UTC
[Nouveau] [PATCH 2/2] drm/nouveau: constify pointers to hwmon_channel_info
Statically allocated array of pointed to hwmon_channel_info can be made const for safety. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> --- This depends on hwmon core patch: https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski at linaro.org/ Therefore I propose this should also go via hwmon tree. Cc: Jean Delvare <jdelvare at suse.com> Cc: Guenter Roeck <linux at roeck-us.net> Cc: linux-hwmon at vger.kernel.org --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c index e844be49e11e..db30a4c2cd4d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c @@ -211,7 +211,7 @@ static const struct attribute_group temp1_auto_point_sensor_group = { #define N_ATTR_GROUPS 3 -static const struct hwmon_channel_info *nouveau_info[] = { +static const struct hwmon_channel_info * const nouveau_info[] = { HWMON_CHANNEL_INFO(chip, HWMON_C_UPDATE_INTERVAL), HWMON_CHANNEL_INFO(temp, -- 2.34.1
Jani Nikula
2023-Apr-11 09:27 UTC
[Nouveau] [PATCH 1/2] drm/i915: constify pointers to hwmon_channel_info
On Fri, 07 Apr 2023, Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> wrote:> Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> > > --- > > This depends on hwmon core patch: > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski at linaro.org/ > > Therefore I propose this should also go via hwmon tree.Thanks for doing this, I couldn't be bothered to follow through with it [1]. Acked-by: Jani Nikula <jani.nikula at intel.com> [1] https://lore.kernel.org/r/20230309082841.400118-1-jani.nikula at intel.com> > Cc: Jean Delvare <jdelvare at suse.com> > Cc: Guenter Roeck <linux at roeck-us.net> > Cc: linux-hwmon at vger.kernel.org > --- > drivers/gpu/drm/i915/i915_hwmon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_hwmon.c b/drivers/gpu/drm/i915/i915_hwmon.c > index 596dd2c07010..87b527a54272 100644 > --- a/drivers/gpu/drm/i915/i915_hwmon.c > +++ b/drivers/gpu/drm/i915/i915_hwmon.c > @@ -267,7 +267,7 @@ static const struct attribute_group *hwm_groups[] = { > NULL > }; > > -static const struct hwmon_channel_info *hwm_info[] = { > +static const struct hwmon_channel_info * const hwm_info[] = { > HWMON_CHANNEL_INFO(in, HWMON_I_INPUT), > HWMON_CHANNEL_INFO(power, HWMON_P_MAX | HWMON_P_RATED_MAX | HWMON_P_CRIT), > HWMON_CHANNEL_INFO(energy, HWMON_E_INPUT), > @@ -275,7 +275,7 @@ static const struct hwmon_channel_info *hwm_info[] = { > NULL > }; > > -static const struct hwmon_channel_info *hwm_gt_info[] = { > +static const struct hwmon_channel_info * const hwm_gt_info[] = { > HWMON_CHANNEL_INFO(energy, HWMON_E_INPUT), > NULL > };-- Jani Nikula, Intel Open Source Graphics Center
Lyude Paul
2023-Apr-13 20:50 UTC
[Nouveau] [PATCH 2/2] drm/nouveau: constify pointers to hwmon_channel_info
Reviewed-by: Lyude Paul <lyude at redhat.com> On Fri, 2023-04-07 at 17:00 +0200, Krzysztof Kozlowski wrote:> Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> > > --- > > This depends on hwmon core patch: > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski at linaro.org/ > > Therefore I propose this should also go via hwmon tree. > > Cc: Jean Delvare <jdelvare at suse.com> > Cc: Guenter Roeck <linux at roeck-us.net> > Cc: linux-hwmon at vger.kernel.org > --- > drivers/gpu/drm/nouveau/nouveau_hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c > index e844be49e11e..db30a4c2cd4d 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c > +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c > @@ -211,7 +211,7 @@ static const struct attribute_group temp1_auto_point_sensor_group = { > > #define N_ATTR_GROUPS 3 > > -static const struct hwmon_channel_info *nouveau_info[] = { > +static const struct hwmon_channel_info * const nouveau_info[] = { > HWMON_CHANNEL_INFO(chip, > HWMON_C_UPDATE_INTERVAL), > HWMON_CHANNEL_INFO(temp,-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
Apparently Analagous Threads
- [PATCH 1/2] drm/i915: constify pointers to hwmon_channel_info
- [PATCH] vdpa: solidrun: constify pointers to hwmon_channel_info
- [PATCH] vdpa: solidrun: constify pointers to hwmon_channel_info
- [PATCH 0/4] nouveau_hwmon: migrate to hwmon_device_register_with_info
- [PATCH v2 1/5] nouveau_hwmon: Add config for all sensors and their settings