Ivan Krylov
2023-Jan-06 07:26 UTC
[Rd] patch about timezone name of China Standard Time on windows
Hello Yu Gong! I'm not an R developer, but I hope I'll be able to help you with my advice. On Fri, 6 Jan 2023 04:24:43 +0000 gong yu <yugong at outlook.com> wrote:> Last week ,I report a issuse about timezone name about" China > Standard Time", R on windows will report to Asia/Taipei , but it > should be Asia/Shanghai, Since still now no feedback (maybe because > for my poor english). So resubmit a patch about this .Sometimes, everyone is too busy to discuss a patch right now, but a patch just left on R-devel may be eventually forgotten before there's time for discussion. Try asking for a Bugzilla account (by following the guide at <https://www.r-project.org/bugs.html>) and submitting the patch there.> and in current R implemention , it report " China Standard Time" is > incorrect ,but "Taipei Standard Time" is correct, so this patch only > need modify " China Standard Time" and will not affect other timezone.Thank you for verifying this. As far as I can tell, the file has always contained both entries referring to "Asia/Taipei": https://github.com/r-devel/r-svn/blame/22bf3a2cb1dd6844e69c9214d990bf438a485db7/src/extra/tzone/registryTZ.c -- Best regards, Ivan
gong yu
2023-Jan-06 09:17 UTC
[Rd] 回复: patch about timezone name of China Standard Time on windows
Thanks Ivan! I really missed the information on https://www.r-project.org/bugs.html . Instead , browse https://bugs.r-project.org<https://bugs.r-project.org/> and didn't found where to registration and login, then send email to this list. will send a email to bug-report-request at r-project.org. for two entries in registryTZ.c<https://github.com/r-devel/r-svn/blame/22bf3a2cb1dd6844e69c9214d990bf438a485db7/src/extra/tzone/registryTZ.c> , the China Standard Time is incorrect ,but Taipei Standard Tim is ok Best regards, Yu Gong ________________________________ ??????: Ivan Krylov <krylov.r00t at gmail.com> ???????: 2023??1??6?? 15:26 ?????: gong yu <yugong at outlook.com> ????: r-devel at r-project.org <r-devel at r-project.org> ????: Re: [Rd] patch about timezone name of China Standard Time on windows Hello Yu Gong! I'm not an R developer, but I hope I'll be able to help you with my advice. On Fri, 6 Jan 2023 04:24:43 +0000 gong yu <yugong at outlook.com> wrote:> Last week ,I report a issuse about timezone name about" China > Standard Time", R on windows will report to Asia/Taipei , but it > should be Asia/Shanghai, Since still now no feedback (maybe because > for my poor english). So resubmit a patch about this .Sometimes, everyone is too busy to discuss a patch right now, but a patch just left on R-devel may be eventually forgotten before there's time for discussion. Try asking for a Bugzilla account (by following the guide at <https://www.r-project.org/bugs.html>) and submitting the patch there.> and in current R implemention , it report " China Standard Time" is > incorrect ,but "Taipei Standard Time" is correct, so this patch only > need modify " China Standard Time" and will not affect other timezone.Thank you for verifying this. As far as I can tell, the file has always contained both entries referring to "Asia/Taipei": https://github.com/r-devel/r-svn/blame/22bf3a2cb1dd6844e69c9214d990bf438a485db7/src/extra/tzone/registryTZ.c -- Best regards, Ivan [[alternative HTML version deleted]]