* make check
When I run make check, the good news is that it seems to pass
everything.
But it looks like it is building man pages that maybe should have been
built during the build.
[snip]
Making check in docs
Making check in man
make check-local
PASSED man-source sanity check (checked 130 files)
DOC-MAN Generating hosts.conf.5
DOC-MAN Generating upsset.conf.5
DOC-MAN Generating upsstats.html.5
DOC-MAN Generating upsset.cgi.8
[snip]
* make install
looks good
* make distcheck
This fails because of missing libneon, but the earlier configure worked.
Is the configure intentionally forcing on all optional things?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL:
<http://alioth-lists.debian.net/pipermail/nut-upsdev/attachments/20220330/357a0bf8/attachment-0001.sig>
Regarding distcheck, like in other autotools projects, it was historically geared towards testing that "everything" (`--with-all`) can be built from tarball, not relying on git/svn/... sources (and possibly relying on generated files like the copy of configure script itself) - and so to check that we `dist` everything needed (maintain `EXTRA_DIST` mostly). It implicitly assumes that the "maintainer's system" is able to build the whole ecosystem, and "others" have moderate need to dist(check) beside verifying they can and did not break it. Eventually this allows to publish the tarball release with peace of mind. It was later extended for some CI scenarios (e.g. bypass docs or not, as a big time hog and disk space user for TeX tooling) and more swathes of code and build/dist scenarios in forks like 42ity/nut, so nowadays that's tunable by passing DISTCHECK_FLAGS and/or DISTCHECK_CONFIGURE_FLAGS make/env vars... You might like to `make distcheck-light` for its `--with-all=auto` mode -- specifically to test against dependencies *your* system has. Alas, not all OSes ship the whole range of third-party code NUT can build against. Jim On Wed, Mar 30, 2022, 19:02 Greg Troxel <gdt at lexort.com> wrote:> > * make check > > When I run make check, the good news is that it seems to pass > everything. > > But it looks like it is building man pages that maybe should have been > built during the build. > > [snip] > Making check in docs > Making check in man > make check-local > PASSED man-source sanity check (checked 130 files) > DOC-MAN Generating hosts.conf.5 > DOC-MAN Generating upsset.conf.5 > DOC-MAN Generating upsstats.html.5 > DOC-MAN Generating upsset.cgi.8 > [snip] > > * make install > > looks good > > * make distcheck > > This fails because of missing libneon, but the earlier configure worked. > Is the configure intentionally forcing on all optional things? > > _______________________________________________ > Nut-upsdev mailing list > Nut-upsdev at alioth-lists.debian.net > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/nut-upsdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://alioth-lists.debian.net/pipermail/nut-upsdev/attachments/20220331/028e7507/attachment-0001.htm>
As for the man page (re)builds, there might be a better way to handle that, but de-facto there are two sets of target lists in docs/man/Makefile.am: * man5_MANS (more for other numbers, other formats) that would build just the pages needed for your drivers, developer features etc. requested by configure script * MAN_MANS and HTML_MANS that would build (and are used to check) all docs there are for a format, regardless of whether you build a driver or daemon for it today. Of these, MAN_MANS are (usually) pre-built and dist'ed in the tarball, so a build system is not required to have asciidoc to package NUT, and can use pages from the tarball "as is". But fair point, I'll add a `make all-man` in PR #1345 spawned to tune builds to cover netbsd better :) On Wed, Mar 30, 2022, 19:02 Greg Troxel <gdt at lexort.com> wrote:> > * make check > > When I run make check, the good news is that it seems to pass > everything. > > But it looks like it is building man pages that maybe should have been > built during the build. > > [snip] > Making check in docs > Making check in man > make check-local > PASSED man-source sanity check (checked 130 files) > DOC-MAN Generating hosts.conf.5 > DOC-MAN Generating upsset.conf.5 > DOC-MAN Generating upsstats.html.5 > DOC-MAN Generating upsset.cgi.8 > [snip] > > * make install > > looks good > > * make distcheck > > This fails because of missing libneon, but the earlier configure worked. > Is the configure intentionally forcing on all optional things? > > _______________________________________________ > Nut-upsdev mailing list > Nut-upsdev at alioth-lists.debian.net > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/nut-upsdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://alioth-lists.debian.net/pipermail/nut-upsdev/attachments/20220331/ed593a3d/attachment.htm>