Christos Chatzaras
2021-Mar-29 19:57 UTC
FreeBSD 13.0-RC4 and Nginx process "stuck" during restart
Hello, I upgrade from 12.2 to 13.0-RC4 and I notice a strange issue with Nginx. When I run "service nginx restart" in some (random) servers it doesn't complete the restart and it "stucks" at "Waiting for PIDS: 20536." . I can kill the 20536 process and then restart completes. procstat -kk 20536: PID TID COMM TDNAME KSTACK 63094 100505 nginx - mi_switch+0xc1 sleepq_catch_signals+0x2e6 sleepq_wait_sig+0x9 _sleep+0x1be kern_sigsuspend+0x164 sys_sigsuspend+0x31 amd64_syscall+0x10c fast_syscall_common+0xf8 I found this commit: https://cgit.freebsd.org/src/commit/?id=dbec10e08808e375365fb2a2462f306e0cdfda32 <https://cgit.freebsd.org/src/commit/?id=dbec10e08808e375365fb2a2462f306e0cdfda32> Could this be related? If yes can we have the patch in releng/13.0 ? Kind regards, Christos Chatzaras
Mark Johnston
2021-Mar-30 13:45 UTC
FreeBSD 13.0-RC4 and Nginx process "stuck" during restart
On Mon, Mar 29, 2021 at 10:57:09PM +0300, Christos Chatzaras wrote:> Hello, > > > I upgrade from 12.2 to 13.0-RC4 and I notice a strange issue with Nginx. > > When I run "service nginx restart" in some (random) servers it doesn't complete the restart and it "stucks" at "Waiting for PIDS: 20536." . > > I can kill the 20536 process and then restart completes. > > > procstat -kk 20536: > > PID TID COMM TDNAME KSTACK > 63094 100505 nginx - mi_switch+0xc1 sleepq_catch_signals+0x2e6 sleepq_wait_sig+0x9 _sleep+0x1be kern_sigsuspend+0x164 sys_sigsuspend+0x31 amd64_syscall+0x10c fast_syscall_common+0xf8 > > > I found this commit: > > https://cgit.freebsd.org/src/commit/?id=dbec10e08808e375365fb2a2462f306e0cdfda32 <https://cgit.freebsd.org/src/commit/?id=dbec10e08808e375365fb2a2462f306e0cdfda32> > > Could this be related? If yes can we have the patch in releng/13.0 ?I think it is hard to say without some testing. Are you able to verify that backporting the patch fixes the hangs?
Jonathan T. Looney
2021-Mar-30 15:40 UTC
FreeBSD 13.0-RC4 and Nginx process "stuck" during restart
On Mon, Mar 29, 2021 at 3:57 PM Christos Chatzaras <chris at cretaforce.gr> wrote:> Hello, > > > I upgrade from 12.2 to 13.0-RC4 and I notice a strange issue with Nginx. > > When I run "service nginx restart" in some (random) servers it > doesn't complete the restart and it "stucks" at "Waiting for PIDS: 20536." . > > I can kill the 20536 process and then restart completes. > > > procstat -kk 20536: > > PID TID COMM TDNAME KSTACK > 63094 100505 nginx - mi_switch+0xc1 > sleepq_catch_signals+0x2e6 sleepq_wait_sig+0x9 _sleep+0x1be > kern_sigsuspend+0x164 sys_sigsuspend+0x31 amd64_syscall+0x10c > fast_syscall_common+0xf8 > > > I found this commit: > > > https://cgit.freebsd.org/src/commit/?id=dbec10e08808e375365fb2a2462f306e0cdfda32 > > Could this be related? >Yes, it could be related. Because of the timing of when we first saw the behavior, I assumed the trigger for the behavior (which remains unknown) only existed in main. However, it is possible that this behavior is now being triggered in 13.0. Are you able to reliably reproduce this? I was never able to do that. A reliable reproduction may help narrow down the change which triggered this behavior. I can certainly MFC the patch to stable/13. re@ will need to decide whether to admit it to the release branch. Jonathan