flac dev - Apr 2022 - issue with flac versions > 1.3.2

Hi everyone,

I've run into an issue on flac versions greater than 1.3.2, both on an
intel macs and apple silicon macs. I've compiled natively for both
platforms and see the same issue on both.

With the compiled flac binary, I can encode and decode files just fine, but
the issue pops up when using a 3rd party utility called "shntool" from
many
years ago.

When running shntool, I'm calling shntool's "len" and
"info" functions.
Basically, shntool recognizes a flac file, knows to use command-line flac
to decode, and decodes the flac file to std out, calling:

flac -d -c -s

and streams the decoded flac data in.

on flac 1.3.2 and earlier, shntool has no problem reading in the decoded
flac data from std out.

But on 1.3.3 and 1.3.4, shntool doesn't seem to recognize the decoded flac
data as valid PCM data.

1. I hope I'm making sense. and
2. What changed in 1.3.3+ that may cause this?

Thanks,
Scott
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/flac-dev/attachments/20220422/7df2e8e4/attachment.htm>

On 04/22/22 02:45 PM, Scott Brown wrote:
> on flac 1.3.2 and earlier, shntool has no problem reading in the decoded
> flac data from std out.
>
> But on 1.3.3 and 1.3.4, shntool doesn't seem to recognize the decoded
> flac data as valid PCM data.
>
> 1. I hope I'm making sense. and
> 2. What changed in 1.3.3+ that may cause this?
Perhaps try doing a git bisect between 1.3.2 and 1.3.3 to find the 
commit that broke things?
Dave

Op vr 22 apr. 2022 om 23:45 schreef Scott Brown <scottcbrown at
gmail.com>:
> 2. What changed in 1.3.3+ that may cause this?
I presume this is because you are working with 24-bit material and
FLAC changed output for such files to WAVEFORMATEXTENSIBLE.

See here:
- https://hydrogenaud.io/index.php?topic=122251.0
- https://hydrogenaud.io/index.php?topic=122179.msg1008563#msg1008563

Kind regards, Martijn van Beurden