Ido Schimmel
2021-Jul-20 14:01 UTC
[Bridge] [PATCH v5 net-next 00/10] Let switchdev drivers offload and unoffload bridge ports at their own convenience
On Tue, Jul 20, 2021 at 04:46:45PM +0300, Vladimir Oltean wrote:> The explicit switchdev offloading API will see further extensions in the > future. > > The patches were split from a larger series for easier review: > https://patchwork.kernel.org/project/netdevbpf/cover/20210718214434.3938850-1-vladimir.oltean at nxp.com/This is not what I meant. I specifically suggested to get the TX forwarding offload first and then extending the API with an argument to opt-in for the replay / cleanup: https://lore.kernel.org/netdev/YPbU20%2Fcjkz04s8b at shredder/> > Tobias Waldekranz (2): > net: bridge: disambiguate offload_fwd_mark > net: bridge: switchdev: recycle unused hwdoms > > Vladimir Oltean (8): > net: dpaa2-switch: use extack in dpaa2_switch_port_bridge_join > net: dpaa2-switch: refactor prechangeupper sanity checks > mlxsw: spectrum: refactor prechangeupper sanity checks > mlxsw: spectrum: refactor leaving an 8021q upper that is a bridge port > net: marvell: prestera: refactor prechangeupper sanity checks > net: switchdev: guard drivers against multiple obj replays on same > bridge port > net: bridge: switchdev: let drivers inform which bridge ports are > offloaded > net: bridge: switchdev object replay helpers for everybody > > .../ethernet/freescale/dpaa2/dpaa2-switch.c | 69 +++- > .../ethernet/marvell/prestera/prestera_main.c | 99 +++-- > .../marvell/prestera/prestera_switchdev.c | 42 ++- > .../marvell/prestera/prestera_switchdev.h | 7 +- > .../net/ethernet/mellanox/mlxsw/spectrum.c | 347 ++++++++++++------ > .../net/ethernet/mellanox/mlxsw/spectrum.h | 4 + > .../mellanox/mlxsw/spectrum_switchdev.c | 28 +- > .../microchip/sparx5/sparx5_switchdev.c | 48 ++- > drivers/net/ethernet/mscc/ocelot_net.c | 115 ++++-- > drivers/net/ethernet/rocker/rocker.h | 9 +- > drivers/net/ethernet/rocker/rocker_main.c | 34 +- > drivers/net/ethernet/rocker/rocker_ofdpa.c | 42 ++- > drivers/net/ethernet/ti/am65-cpsw-nuss.c | 34 +- > drivers/net/ethernet/ti/am65-cpsw-switchdev.c | 14 +- > drivers/net/ethernet/ti/am65-cpsw-switchdev.h | 3 + > drivers/net/ethernet/ti/cpsw_new.c | 32 +- > drivers/net/ethernet/ti/cpsw_switchdev.c | 4 +- > drivers/net/ethernet/ti/cpsw_switchdev.h | 3 + > include/linux/if_bridge.h | 60 +-- > net/bridge/br_fdb.c | 1 - > net/bridge/br_if.c | 11 +- > net/bridge/br_mdb.c | 1 - > net/bridge/br_private.h | 61 ++- > net/bridge/br_switchdev.c | 254 +++++++++++-- > net/bridge/br_vlan.c | 1 - > net/dsa/port.c | 83 ++--- > 26 files changed, 1059 insertions(+), 347 deletions(-) > > -- > 2.25.1 >
Vladimir Oltean
2021-Jul-20 14:12 UTC
[Bridge] [PATCH v5 net-next 00/10] Let switchdev drivers offload and unoffload bridge ports at their own convenience
On Tue, Jul 20, 2021 at 05:01:48PM +0300, Ido Schimmel wrote:> > The patches were split from a larger series for easier review: > > This is not what I meant. I specifically suggested to get the TX > forwarding offload first and then extending the API with an argument to > opt-in for the replay / cleanup:Yeah, ok, I did not get that and I had already reposted by the time you clarified, sorry. Anyway, is it so bad that we cannot look at the patches in the order that they are in right now (even if this means that maybe a few more days would pass)? To me it makes a bit more sense anyway to first consolidate the code that is already in the tree right now, before adding new logic. And I don't really want to rebase the patches again to change the ordering and risk a build breakage without a good reason.