On 3/10/22 16:14, Perttu Aaltonen wrote:> I did some more digging and looks like the problem is the interaction > between "fruit:encoding = native? and "fruit:delete_empty_adfiles > yes?. > > If encoding is ?native' and delete_empty_adfiles if ?yes?, the > '._Icon'$'\r? file is deleted from the folder. After setting encoding > to ?private? the '._Icon?? file is retained. > > The documentation says: > > ?fruit:delete_empty_adfiles = yes | no Whether to delete empty > AppleDouble files. Empty means that the resource fork entry in the > AppleDouble files is of size 0, or the size is exactly 286 bytes and > the content matches a special boilerplate resource fork created my > macOS.? > > The icon file will vary in size so setting ?native? seems to > erroneously remove it. I tested with 4.13.7 and 4.15.5.wow, interesting bug! :) Can you please file a bug so we can track this? Thanks! -slow -- Ralph Boehme, Samba Team https://samba.org/ SerNet Samba Team Lead https://sernet.de/en/team-samba -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_signature Type: application/pgp-signature Size: 840 bytes Desc: OpenPGP digital signature URL: <http://lists.samba.org/pipermail/samba/attachments/20220310/1aaebb9c/OpenPGP_signature.sig>
> On 10. Mar 2022, at 17.53, Ralph Boehme <slow at samba.org> wrote: > > On 3/10/22 16:14, Perttu Aaltonen wrote: >> I did some more digging and looks like the problem is the interaction >> between "fruit:encoding = native? and "fruit:delete_empty_adfiles >> yes?. >> If encoding is ?native' and delete_empty_adfiles if ?yes?, the >> '._Icon'$'\r? file is deleted from the folder. After setting encoding >> to ?private? the '._Icon?? file is retained. >> The documentation says: >> ?fruit:delete_empty_adfiles = yes | no Whether to delete empty >> AppleDouble files. Empty means that the resource fork entry in the >> AppleDouble files is of size 0, or the size is exactly 286 bytes and >> the content matches a special boilerplate resource fork created my >> macOS.? >> The icon file will vary in size so setting ?native? seems to >> erroneously remove it. I tested with 4.13.7 and 4.15.5. > > wow, interesting bug! :) Can you please file a bug so we can track this? > > Thanks! > -slow >Will do! By the way, is there a reference somewhere about the pros and cons of using fruit encoding native versus private? Most examples seem to use native but why is private the default and what?s the downside? -Perttu
> On 10. Mar 2022, at 17.53, Ralph Boehme <slow at samba.org> wrote: > > On 3/10/22 16:14, Perttu Aaltonen wrote: >> I did some more digging and looks like the problem is the interaction >> between "fruit:encoding = native? and "fruit:delete_empty_adfiles >> yes?. >> If encoding is ?native' and delete_empty_adfiles if ?yes?, the >> '._Icon'$'\r? file is deleted from the folder. After setting encoding >> to ?private? the '._Icon?? file is retained. >> The documentation says: >> ?fruit:delete_empty_adfiles = yes | no Whether to delete empty >> AppleDouble files. Empty means that the resource fork entry in the >> AppleDouble files is of size 0, or the size is exactly 286 bytes and >> the content matches a special boilerplate resource fork created my >> macOS.? >> The icon file will vary in size so setting ?native? seems to >> erroneously remove it. I tested with 4.13.7 and 4.15.5. > > wow, interesting bug! :) Can you please file a bug so we can track this? > > Thanks! > -slow >Here?s the bug report: https://bugzilla.samba.org/show_bug.cgi?id=15013 I was slightly mistaken. On 4.14 the '._Icon'$'\r? file is deleted or never created and on 4.15 it is created but seem to be locked and the icon never appears. -Perttu