samba - Dec 2020 - Strange logs: check_usershare_stat: file /var/lib/samba/usershares/ owned by uid 0 is not a regular file

On Tue, Dec 01, 2020 at 10:46:05PM +0000, Rowland penny via samba
wrote:
>On 01/12/2020 22:35, Jeremy Allison wrote:
>>On Tue, Dec 01, 2020 at 10:32:32PM +0000, Rowland penny via samba wrote:
>>>On 01/12/2020 22:23, Andrew Bartlett wrote:
>>>>On Tue, 2020-12-01 at 14:19 -0800, Jeremy Allison via samba
wrote:
>>>>>On Tue, Dec 01, 2020 at 10:08:34PM +0000, Rowland penny via
samba
>>>>>wrote:
>>>>>
>>>>>>could this have anything to do with it:
>>>>>>
>>>>>>4.12.0
>>>>>>Default: usershare max shares = 0
>>>>>>
>>>>>>4.13.2
>>>>>>Default: usershare max shares = 100
>>>>>Good catch. Yes, that would cause
>>>>>the usershare load path to be executed
>>>>>now whereas it wasn't before.
>>>>Even if we didn't change the default, Debian does.? But the
code should
>>>>work of course, be it enabled by default or by the
administrator...
>>>>
>>>>Andrew Bartlett
>>>
>>>Yes, it is Debian, just found this out by downloading the relevant 
>>>file from Louis's repo, they appear to be turning usershares on 
>>>without actually setting up usershares. I would suggest the code 
>>>would work if usershares were actually set up correctly, I have 
>>>used usershares in the past and I don't remember syslog getting 
>>>spammed.
>>
>>Well I still don't know why he's seeing syslog spam from
>>an empty usershare directory. That shouldn't happen even
>>if the code is going down the usershare path now.
>
>He is not alone, I didn't know I had a problem until I checked syslog, 
>my lines are bit different:
>
>Dec? 1 09:14:25 raspberrypi smbd[21036]: [2020/12/01 09:14:25.671948,? 
>0] ../../source3/param/loadparm.c:3422(process_usershare_file)
>Dec? 1 09:14:25 raspberrypi smbd[21036]:?? process_usershare_file: 
>stat of /var/lib/samba/usershares/profiles.v6 failed. Permission 
>denied
Hang on a minute - the above says "Permission denied"
for "/var/lib/samba/usershares/profiles.v6"

That means the directory scanner found something
inside:

/var/lib/samba/usershares
>Dec? 1 09:14:25 raspberrypi smbd[21036]: [2020/12/01 09:14:25.676259,? 
>0] ../../source3/param/loadparm.c:3422(process_usershare_file)
>Dec? 1 09:14:25 raspberrypi smbd[21036]:?? process_usershare_file: 
>stat of /var/lib/samba/usershares/profiles.v6 failed. No such file or 
>directory
Now it says "No such file or directory" for
"/var/lib/samba/usershares/profiles.v6"

Which is right ?

On 01/12/2020 22:55, Jeremy Allison wrote:
> On Tue, Dec 01, 2020 at 10:46:05PM +0000, Rowland penny via samba wrote:
>> On 01/12/2020 22:35, Jeremy Allison wrote:
>>> On Tue, Dec 01, 2020 at 10:32:32PM +0000, Rowland penny via samba 
>>> wrote:
>>>> On 01/12/2020 22:23, Andrew Bartlett wrote:
>>>>> On Tue, 2020-12-01 at 14:19 -0800, Jeremy Allison via samba
wrote:
>>>>>> On Tue, Dec 01, 2020 at 10:08:34PM +0000, Rowland penny
via samba
>>>>>> wrote:
>>>>>>
>>>>>>> could this have anything to do with it:
>>>>>>>
>>>>>>> 4.12.0
>>>>>>> Default: usershare max shares = 0
>>>>>>>
>>>>>>> 4.13.2
>>>>>>> Default: usershare max shares = 100
>>>>>> Good catch. Yes, that would cause
>>>>>> the usershare load path to be executed
>>>>>> now whereas it wasn't before.
>>>>> Even if we didn't change the default, Debian does.? But
the code
>>>>> should
>>>>> work of course, be it enabled by default or by the
administrator...
>>>>>
>>>>> Andrew Bartlett
>>>>
>>>> Yes, it is Debian, just found this out by downloading the
relevant
>>>> file from Louis's repo, they appear to be turning
usershares on
>>>> without actually setting up usershares. I would suggest the
code
>>>> would work if usershares were actually set up correctly, I have
>>>> used usershares in the past and I don't remember syslog
getting
>>>> spammed.
>>>
>>> Well I still don't know why he's seeing syslog spam from
>>> an empty usershare directory. That shouldn't happen even
>>> if the code is going down the usershare path now.
>>
>> He is not alone, I didn't know I had a problem until I checked 
>> syslog, my lines are bit different:
>>
>> Dec? 1 09:14:25 raspberrypi smbd[21036]: [2020/12/01 
>> 09:14:25.671948,? 0] 
>> ../../source3/param/loadparm.c:3422(process_usershare_file)
>> Dec? 1 09:14:25 raspberrypi smbd[21036]: process_usershare_file: stat 
>> of /var/lib/samba/usershares/profiles.v6 failed. Permission denied
>
> Hang on a minute - the above says "Permission denied"
> for "/var/lib/samba/usershares/profiles.v6"
>
> That means the directory scanner found something
> inside:
>
> /var/lib/samba/usershares
>
>> Dec? 1 09:14:25 raspberrypi smbd[21036]: [2020/12/01 
>> 09:14:25.676259,? 0] 
>> ../../source3/param/loadparm.c:3422(process_usershare_file)
>> Dec? 1 09:14:25 raspberrypi smbd[21036]: process_usershare_file: stat 
>> of /var/lib/samba/usershares/profiles.v6 failed. No such file or 
>> directory
>
> Now it says "No such file or directory" for
> "/var/lib/samba/usershares/profiles.v6"
>
> Which is right ?
There is nothing inside /var/lib/samba/usershares , do you think I would 
put profiles inside a usershare ?

Rowland