Jakub Kicinski
2020-Oct-15 17:34 UTC
[Bridge] [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.
On Thu, 15 Oct 2020 11:54:15 +0000 Henrik Bjoernlund wrote:> + [IFLA_BRIDGE_CFM_MEP_CONFIG_MDLEVEL] = { > + .type = NLA_U32, .validation_type = NLA_VALIDATE_MAX, .max = 7 },NLA_POLICY_MAX(NLA_U32, 7) Also why did you keep the validation in the code in patch 4?
Henrik Bjoernlund
2020-Oct-19 08:51 UTC
[Bridge] [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.
Thank you for the review. Comments below. The 10/15/2020 10:34, Jakub Kicinski wrote:> > On Thu, 15 Oct 2020 11:54:15 +0000 Henrik Bjoernlund wrote: > > + [IFLA_BRIDGE_CFM_MEP_CONFIG_MDLEVEL] = { > > + .type = NLA_U32, .validation_type = NLA_VALIDATE_MAX, .max = 7 }, > > NLA_POLICY_MAX(NLA_U32, 7)I will change as requested.> > Also why did you keep the validation in the code in patch 4?In patch 4 there is no CFM NETLINK so I desided to keep the validation in the code until NETLINK was added that is now doing the check. I this a problem? -- /Henrik