Arvind Yadav
2017-Jun-29 11:10 UTC
[Bridge] [PATCH] net: bridge: constify attribute_group structures.
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 2645 896 0 3541 dd5 net/bridge/br_sysfs_br.o File size After adding 'const': text data bss dec hex filename 2701 832 0 3533 dcd net/bridge/br_sysfs_br.o Signed-off-by: Arvind Yadav <arvind.yadav.cs at gmail.com> --- net/bridge/br_sysfs_br.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c index 0b5dd60..723f25e 100644 --- a/net/bridge/br_sysfs_br.c +++ b/net/bridge/br_sysfs_br.c @@ -865,7 +865,7 @@ static ssize_t vlan_stats_enabled_store(struct device *d, NULL }; -static struct attribute_group bridge_group = { +static const struct attribute_group bridge_group = { .name = SYSFS_BRIDGE_ATTR, .attrs = bridge_attrs, }; -- 1.9.1
David Miller
2017-Jun-29 19:50 UTC
[Bridge] [PATCH] net: bridge: constify attribute_group structures.
From: Arvind Yadav <arvind.yadav.cs at gmail.com> Date: Thu, 29 Jun 2017 16:39:38 +0530> attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by <linux/sysfs.h> work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 2645 896 0 3541 dd5 net/bridge/br_sysfs_br.o > > File size After adding 'const': > text data bss dec hex filename > 2701 832 0 3533 dcd net/bridge/br_sysfs_br.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs at gmail.com>Applied.