Cong Wang
2015-Jan-13 19:25 UTC
[Bridge] [PATCH] bridge: only provide proxy ARP when CONFIG_INET is enabled
On Tue, Jan 13, 2015 at 6:10 AM, Arnd Bergmann <arnd at arndb.de> wrote:> When IPV4 support is disabled, we cannot call arp_send from > the bridge code, which would result in a kernel link error: > > net/built-in.o: In function `br_handle_frame_finish': > :(.text+0x59914): undefined reference to `arp_send' > :(.text+0x59a50): undefined reference to `arp_tbl' > > This makes the newly added proxy ARP support in the bridge > code depend on the CONFIG_INET symbol and lets the compiler > optimize the code out to avoid the link error. >Not sure how much sense to make CONFIG_BRIDGE depend on CONFIG_INET, at least CONFIG_BONDING does.
David Miller
2015-Jan-13 20:57 UTC
[Bridge] [PATCH] bridge: only provide proxy ARP when CONFIG_INET is enabled
From: Cong Wang <cwang at twopensource.com> Date: Tue, 13 Jan 2015 11:25:45 -0800> On Tue, Jan 13, 2015 at 6:10 AM, Arnd Bergmann <arnd at arndb.de> wrote: >> When IPV4 support is disabled, we cannot call arp_send from >> the bridge code, which would result in a kernel link error: >> >> net/built-in.o: In function `br_handle_frame_finish': >> :(.text+0x59914): undefined reference to `arp_send' >> :(.text+0x59a50): undefined reference to `arp_tbl' >> >> This makes the newly added proxy ARP support in the bridge >> code depend on the CONFIG_INET symbol and lets the compiler >> optimize the code out to avoid the link error. >> > > Not sure how much sense to make CONFIG_BRIDGE depend > on CONFIG_INET, at least CONFIG_BONDING does.It depends upon whether we want to provide and consider as a valid configuration bridging without INET. Probably we do.