Daeseok Youn
2015-Feb-23 10:38 UTC
[Ocfs2-devel] [PATCH 1/3] ocfs2: remove unneeded variable 'status'
Use 'retval' instead of 'status'. Signed-off-by: Daeseok Youn <daeseok.youn at gmail.com> --- fs/ocfs2/dir.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index b08050b..1478a50 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -1617,7 +1617,7 @@ int __ocfs2_add_entry(handle_t *handle, struct ocfs2_dir_entry *de, *de1; struct ocfs2_dinode *di = (struct ocfs2_dinode *)parent_fe_bh->b_data; struct super_block *sb = dir->i_sb; - int retval, status; + int retval; unsigned int size = sb->s_blocksize; struct buffer_head *insert_bh = lookup->dl_leaf_bh; char *data_start = insert_bh->b_data; @@ -1695,22 +1695,22 @@ int __ocfs2_add_entry(handle_t *handle, } if (insert_bh == parent_fe_bh) - status = ocfs2_journal_access_di(handle, + retval = ocfs2_journal_access_di(handle, INODE_CACHE(dir), insert_bh, OCFS2_JOURNAL_ACCESS_WRITE); else { - status = ocfs2_journal_access_db(handle, + retval = ocfs2_journal_access_db(handle, INODE_CACHE(dir), insert_bh, OCFS2_JOURNAL_ACCESS_WRITE); if (ocfs2_dir_indexed(dir)) { - status = ocfs2_dx_dir_insert(dir, + retval = ocfs2_dx_dir_insert(dir, handle, lookup); - if (status) { - mlog_errno(status); + if (retval) { + mlog_errno(retval); goto bail; } } -- 1.7.1
Andrew Morton
2015-Feb-26 21:33 UTC
[Ocfs2-devel] [PATCH 1/3] ocfs2: remove unneeded variable 'status'
On Mon, 23 Feb 2015 19:38:10 +0900 Daeseok Youn <daeseok.youn at gmail.com> wrote:> Use 'retval' instead of 'status'. >The patch does a lot more than this. It causes __ocfs2_add_entry to propagate error codes which were previously dropped on the floor. Please update the changelog to fully explain the functional changes and to explain why they are desirable. After the patch there is still one unchecked call to ocfs2_journal_access_di() and one unchecked call to ocfs2_journal_access_db(). Probably these are bugs.