freebsd stable - May 2018 - pdeathsig_helper and .debug/pdeathsig_helper.debug placed in /mnt when DESTDIR=/mnt

On Wed, May 09, 2018 at 06:44:09PM +0200, Trond Endrest?l
wrote:
> On Wed, 9 May 2018 16:50+0300, Konstantin Belousov wrote:
> 
> > On Wed, May 09, 2018 at 02:49:34PM +0200, Trond Endrest?l wrote:
> > > I noticed two new entries in / after running make installworld
today
> > > using amd64 stable/11 r333390:
> > > 
> > > # LANG=en_US.UTF-8 ls -lT /pdeathsig_helper
/.debug/pdeathsig_helper.debug
> > > -r--r--r--  1 root  wheel  7528 May  9 12:06:58 2018
/.debug/pdeathsig_helper.debug
> > > -r-xr-xr-x  1 root  wheel  8576 May  9 12:06:58 2018
/pdeathsig_helper
> > > 
> > > I'm sure these belong in /usr/tests/sys/kern. This must have
happened
> > > in r333162 or shortly after.
> > > 
> > > See PR 228018, of which I hijacked.
> > 
> > Can you try this ?
> > 
> > Index: tests/sys/kern/Makefile
> > ==================================================================>
> --- tests/sys/kern/Makefile	(revision 333400)
> > +++ tests/sys/kern/Makefile	(working copy)
> > @@ -4,6 +4,7 @@
> >  .PATH:		${SRCTOP}/sys/kern
> >  
> >  TESTSDIR=	${TESTSBASE}/sys/kern
> > +BINDIR=		${TESTDIR}
There is a type, it should be TESTSDIR.

Index: tests/sys/kern/Makefile
==================================================================---
tests/sys/kern/Makefile	(revision 333400)
+++ tests/sys/kern/Makefile	(working copy)
@@ -4,6 +4,7 @@
 .PATH:		${SRCTOP}/sys/kern
 
 TESTSDIR=	${TESTSBASE}/sys/kern
+BINDIR=		${TESTSDIR}
 
 ATF_TESTS_C+=	kern_copyin
 ATF_TESTS_C+=	kern_descrip_test

On Wed, 9 May 2018 20:39+0300, Konstantin Belousov wrote:
> On Wed, May 09, 2018 at 06:44:09PM +0200, Trond Endrest?l wrote:
> > On Wed, 9 May 2018 16:50+0300, Konstantin Belousov wrote:
> > 
> > > On Wed, May 09, 2018 at 02:49:34PM +0200, Trond Endrest?l wrote:
> > > > I noticed two new entries in / after running make
installworld today
> > > > using amd64 stable/11 r333390:
> > > > 
> > > > # LANG=en_US.UTF-8 ls -lT /pdeathsig_helper
/.debug/pdeathsig_helper.debug
> > > > -r--r--r--  1 root  wheel  7528 May  9 12:06:58 2018
/.debug/pdeathsig_helper.debug
> > > > -r-xr-xr-x  1 root  wheel  8576 May  9 12:06:58 2018
/pdeathsig_helper
> > > > 
> > > > I'm sure these belong in /usr/tests/sys/kern. This must
have happened
> > > > in r333162 or shortly after.
> > > > 
> > > > See PR 228018, of which I hijacked.
> > > 
> > > Can you try this ?
> > > 
> > > Index: tests/sys/kern/Makefile
> > >
==================================================================> > >
--- tests/sys/kern/Makefile	(revision 333400)
> > > +++ tests/sys/kern/Makefile	(working copy)
> > > @@ -4,6 +4,7 @@
> > >  .PATH:		${SRCTOP}/sys/kern
> > >  
> > >  TESTSDIR=	${TESTSBASE}/sys/kern
> > > +BINDIR=		${TESTDIR}
> There is a type, it should be TESTSDIR.
> 
> Index: tests/sys/kern/Makefile
> ==================================================================> ---
tests/sys/kern/Makefile	(revision 333400)
> +++ tests/sys/kern/Makefile	(working copy)
> @@ -4,6 +4,7 @@
>  .PATH:		${SRCTOP}/sys/kern
>  
>  TESTSDIR=	${TESTSBASE}/sys/kern
> +BINDIR=		${TESTSDIR}
>  
>  ATF_TESTS_C+=	kern_copyin
>  ATF_TESTS_C+=	kern_descrip_test
I should've guessed that when I looked at the siblings.
Anyway, the builder is nearly finished and the patch is in place.
We'll soon find out.

-- 
Trond.

On Wed, 9 May 2018 20:39+0300, Konstantin Belousov wrote:
> There is a typo, it should be TESTSDIR.
> 
> Index: tests/sys/kern/Makefile
> ==================================================================> ---
tests/sys/kern/Makefile	(revision 333400)
> +++ tests/sys/kern/Makefile	(working copy)
> @@ -4,6 +4,7 @@
>  .PATH:		${SRCTOP}/sys/kern
>  
>  TESTSDIR=	${TESTSBASE}/sys/kern
> +BINDIR=		${TESTSDIR}
>  
>  ATF_TESTS_C+=	kern_copyin
>  ATF_TESTS_C+=	kern_descrip_test
This looks more promising:

--- realinstall_subdir_tests ---
--- pdeathsig_helper.install ---
(cd /usr/src/tests/sys/kern &&  DEPENDFILE=.depend.pdeathsig_helper 
NO_SUBDIR=1 make -f /usr/src/tests/sys/kern/Makefile _RECURSING_PROGS=t 
PROG=pdeathsig_helper  install)
--- realinstall_subdir_usr.sbin ---
install  -o root -g wheel -m 444 unbound.conf.5.gz  /mnt/usr/share/man/man5/
--- realinstall_subdir_usr.sbin/unbound/anchor ---
===> usr.sbin/unbound/anchor (install)
--- realinstall_subdir_tests ---
--- _proginstall ---
install  -s -o root -g wheel -m 555   pdeathsig_helper
/mnt/usr/tests/sys/kern/pdeathsig_helper
--- realinstall_subdir_usr.sbin ---
--- _proginstall ---
install  -s -o root -g wheel -m 555   unbound-anchor
/mnt/usr/sbin/unbound-anchor
--- realinstall_subdir_tests ---
install  -o root -g wheel -m 444  pdeathsig_helper.debug
/mnt/usr/lib/debug/usr/tests/sys/kern/pdeathsig_helper.debug
--- realinstall_subdir_usr.sbin ---
install  -o root -g wheel -m 444  unbound-anchor.debug
/mnt/usr/lib/debug/usr/sbin/unbound-anchor.debug

But this one's persistent:

--- realinstall_subdir_tests ---
--- subr_unit_test.install ---
(cd /usr/src/tests/sys/kern &&  DEPENDFILE=.depend.subr_unit_test 
NO_SUBDIR=1 make -f /usr/src/tests/sys/kern/Makefile _RECURSING_PROGS=t 
PROG=subr_unit_test  install)
--- realinstall_subdir_usr.sbin ---
install  -o root -g wheel -m 444  ancontrol.debug
/mnt/usr/lib/debug/usr/sbin/ancontrol.debug
--- maninstall ---
install  -o root -g wheel -m 444 ancontrol.8.gz  /mnt/usr/share/man/man8/
--- realinstall_subdir_usr.sbin/wlandebug ---
===> usr.sbin/wlandebug (install)
--- realinstall_subdir_tests ---
--- _proginstall ---
install  -s -o root -g wheel -m 555   subr_unit_test
/mnt/usr/tests/sys/kern/subr_unit_test
install  -o root -g wheel -m 444  subr_unit_test.debug
/mnt/usr/lib/debug/usr/tests/sys/kern/subr_unit_test.debug
--- realinstall_subdir_usr.sbin ---
--- _proginstall ---
install  -s -o root -g wheel -m 555   wlandebug /mnt/usr/sbin/wlandebug
--- realinstall_subdir_tests ---
--- Kyuafile ---
sh: cannot create Kyuafile.tmp: Read-only file system
sh: cannot create Kyuafile.tmp: Read-only file system
*** [Kyuafile] Error code 2

make[6]: stopped in /usr/src/tests/sys/kern
1 error

-- 
Trond.