llvm dev - Apr 2021 - Anyone doing code reviews via mailing lists?

On Fri, 23 Apr 2021, Renato Golin via llvm-dev wrote:
> Yeah, I can't remember the last time I did a review by email. But
I'm sure
> that they were replies to a commit that broke our bots, and not an actual
> review of a pull request.
> Worse, I think if someone does a review by email and doesn't copy me
> directly, I won't even notice. 
Especially for cases where a commit didn't go through review on 
Phabricator, it's probably common to react to it via e.g. a reply to the 
commit mail, as it both goes to the list and hopefully reaches the author 
that way.

// Martin

As an interesting coincidence and data point, my sony.com email just got
CC'ed to a new patch request, posted directly on llvm-commits. I'm
guessing
the email  actually bounced or got stuck in some sort of moderation queue,
as I haven't seen it appear in the archives to link to it directly. Anyway,
it appears the user didn't know about Phabricator being the preferred
method (not helped due to the previously mentioned documentation no doubt),
so I've pointed them at it, along with the relevant llvm.org pages to help
them out.

(+1 to the side point of switching entirely to Phabricator reviews by the
way)

On Fri, 23 Apr 2021 at 21:43, Martin Storsjö via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> On Fri, 23 Apr 2021, Renato Golin via llvm-dev wrote:
>
> > Yeah, I can't remember the last time I did a review by email. But
I'm
> sure
> > that they were replies to a commit that broke our bots, and not an
actual
> > review of a pull request.
> > Worse, I think if someone does a review by email and doesn't copy
me
> > directly, I won't even notice.
>
> Especially for cases where a commit didn't go through review on
> Phabricator, it's probably common to react to it via e.g. a reply to
the
> commit mail, as it both goes to the list and hopefully reaches the author
> that way.
>
> // Martin
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20210426/d465b41e/attachment.html>