Craig Topper via llvm-dev
2021-Feb-01 22:11 UTC
[llvm-dev] Conflicting check prefix detection not working in update_llc_test_checks.py?
update_llc_test_checks.py seems to not be telling me about assembly that differs under the same prefix anymore. An easy way to see this is to just remove the --check-prefix from test/CodeGen/RISCV/alu32.ll and run the script. You'll get no error about conflicts. And if you look at the resulting file only some functions will have been updated to use CHECK as the prefix. Reverting some commits to update_llc_test_checks.py suggest this may have been broken by e2dc306b1ac71258e6ce40a66e778527f282c355 [utils] Fix UpdateTestChecks case where 2 runs differ for last label ~Craig -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210201/c66bc5ec/attachment.html>
Mircea Trofin via llvm-dev
2021-Feb-01 22:12 UTC
[llvm-dev] Conflicting check prefix detection not working in update_llc_test_checks.py?
looking On Mon, Feb 1, 2021 at 2:11 PM Craig Topper <craig.topper at gmail.com> wrote:> update_llc_test_checks.py seems to not be telling me about assembly that > differs under the same prefix anymore. > > An easy way to see this is to just remove the --check-prefix from > test/CodeGen/RISCV/alu32.ll and run the script. You'll get no error about > conflicts. And if you look at the resulting file only some functions will > have been updated to use CHECK as the prefix. > > Reverting some commits to update_llc_test_checks.py suggest this may have > been broken by e2dc306b1ac71258e6ce40a66e778527f282c355 [utils] Fix > UpdateTestChecks case where 2 runs differ for last label > > ~Craig >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210201/dd85f6ce/attachment.html>