openssh unix dev - Oct 2021 - Disable tracing on FreeBSD using procctl. (OpenSSH Portable 8.8)

On 10/14/2021 8:44 PM, Darren Tucker wrote:
> On Fri, 15 Oct 2021 at 10:48, mike tancsa <mike at sentex.net> wrote:
>>       With the commit below, OpenSSH portable 8.8 doesnt seem to work
>> with sftp on FreeBSD with RELENG_12 and RELENG_13.  sftp errors out
with
>>
>> sftp-server[89445]: fatal: unable to make the process untraceable
> As a data point,our github CI tests on FreeBSD 12 & 13 VMs and our
> test suite passes on them.  I have confirmed that both set
> HAVE_PROCCTL and that the code is being compiled in and just run a
> manual test on 13 which worked.
>
Thanks, I am not sure why its failing on these particular instances. I 
tried just now on a separate box that has not had a previous version 
installed and it doesnt show the same behaviour. I will keep looking to 
see whats going on.

 ??? ---Mike

On Fri, 15 Oct 2021 at 12:37, mike tancsa <mike at sentex.net>
wrote:
> Thanks, I am not sure why its failing on these particular instances. I
> tried just now on a separate box that has not had a previous version
> installed and it doesnt show the same behaviour. I will keep looking to
> see whats going on.
Did you start from a point where tracing is already disabled?  I could
imagine the second attempt to disable it failing because it was
already disabled.

If nothing else we should at least include the errno in the message
when it fails:
https://github.com/openssh/openssh-portable/commit/fff13aaa262b7b3ec83ed21e29674cbf331780a7

-- 
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.