openssh unix dev - Oct 2021 - Disable tracing on FreeBSD using procctl. (OpenSSH Portable 8.8)

Hi,

 ??? With the commit below, OpenSSH portable 8.8 doesnt seem to work 
with sftp on FreeBSD with RELENG_12 and RELENG_13.? sftp errors out with

sftp-server[89445]: fatal: unable to make the process untraceable

commit 2d678c5e3bdc2f5c99f7af5122e9d054925d560d
Author: David Carlier <devnexen at gmail.com>
Date:?? Wed Sep 8 19:49:54 2021 +0100

 ??? Disable tracing on FreeBSD using procctl.

 ??? Placed at the start of platform_disable_tracing() to prevent 
declaration
 ??? after code errors from strict C89 compilers (in the unlikely event that
 ??? more than one method is enabled).

I opened a PR with the port maintainer

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259174

 ??? ---Mike

On Fri, 15 Oct 2021 at 10:48, mike tancsa <mike at sentex.net>
wrote:
>      With the commit below, OpenSSH portable 8.8 doesnt seem to work
> with sftp on FreeBSD with RELENG_12 and RELENG_13.  sftp errors out with
>
> sftp-server[89445]: fatal: unable to make the process untraceable
As a data point,our github CI tests on FreeBSD 12 & 13 VMs and our
test suite passes on them.  I have confirmed that both set
HAVE_PROCCTL and that the code is being compiled in and just run a
manual test on 13 which worked.

FreeBSD fbsd12 12.2-RELEASE-p3 FreeBSD 12.2-RELEASE-p3 GENERIC  amd64

FreeBSD fbsd13 13.0-RELEASE FreeBSD 13.0-RELEASE #0
releng/13.0-n244733-ea31abc261f: Fri Apr  9 04:24:09 UTC 2021
root at releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC
amd64

-- 
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.