Libguestfs - Oct 2022 - libnbd | Failed pipeline for master | 018d55a8

On Wed, Oct 12, 2022 at 05:53:51PM +0000, GitLab wrote:
> 
> 
> Pipeline #665159249 has failed!
> 
> Project: libnbd ( https://gitlab.com/nbdkit/libnbd )
> Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master )
> 
> Commit: 018d55a8 (
https://gitlab.com/nbdkit/libnbd/-/commit/018d55a83be047824017e23eec6c0ed25b16a730
)
> Commit Message: tests: Skip rather than fail on missing nbdkit ...
> Commit Author: Eric Blake ( https://gitlab.com/ebblake )
> 
> Pipeline #665159249 (
https://gitlab.com/nbdkit/libnbd/-/pipelines/665159249 ) triggered by Eric Blake
( https://gitlab.com/ebblake )
> had 3 failed jobs.
Yay - forcing a container rebuild fixed the alpine-315 problem in the
previous run (where the alpine container was broken from a timeout
during the previous container build).  Thanks to danpb on IRC for the
hint (documenting it here if I need to do it again:
<danpb> eblake: assuming you have admin rights, go to 
https://gitlab.com/nbdkit/libnbd/-/pipelines
<danpb> eblake: and hit  'Run pipeline' and in the form that
appears
<danpb> eblake: select 'master' branch, and then  enter a variable
'RUN_CONTAINER_BUILDS'  with a value of  1
<danpb> eblake:  that will force a recreation of all container images from
currently committed master
)

However, even with that fixed,
> 
> Job #3163966652 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3163966652/raw )
> 
> Stage: builds
> Name: i686-debian-11-prebuilt-env
> Job #3163966650 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3163966650/raw )
> 
> Stage: builds
> Name: i686-debian-10-prebuilt-env
these two are new failures, due to a typo in upstream lcitool; merge
request for that pending at
https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/327, and I'm
pushing a patch with files regenerated with that lcitool fix applied.
> Job #3163966643 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3163966643/raw )
> 
> Stage: builds
> Name: x86_64-opensuse-leap-153-prebuilt-env
This one is still failing because of a bug in gnutls; the log is
reporting:

libnbd: debug: nbd1: nbd_connect_command: transition:
NEWSTYLE.OPT_STARTTLS.RECV_REPLY_PAYLOAD -> NEWSTYLE.OPT_STARTTLS.CHECK_REPLY
free(): invalid pointer
libnbd: debug: nbd1: nbd_connect_command: transition:
NEWSTYLE.OPT_STARTTLS.CHECK_REPLY -> NEWSTYLE.OPT_STARTTLS.TLS_HANDSHAKE_READ
libnbd: debug: nbd1: nbd_connect_command: transition:
NEWSTYLE.OPT_STARTTLS.TLS_HANDSHAKE_READ -> DEAD
libnbd: debug: nbd1: nbd_connect_command: leave:
error="nbd_connect_command: gnutls_handshake: Error in the pull function.
(-1/1)"

That libc message about invalid free() is scary; I'm not yet sure
whether it is a bug in opensuse-leap's gnutls package or something
we're doing wrong in libnbd.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

On Wed, Oct 12, 2022 at 02:00:21PM -0500, Eric Blake
wrote:
> > Job #3163966643 (
https://gitlab.com/nbdkit/libnbd/-/jobs/3163966643/raw )
> > 
> > Stage: builds
> > Name: x86_64-opensuse-leap-153-prebuilt-env
> 
> This one is still failing because of a bug in gnutls; the log is
> reporting:
> 
> libnbd: debug: nbd1: nbd_connect_command: transition:
NEWSTYLE.OPT_STARTTLS.RECV_REPLY_PAYLOAD -> NEWSTYLE.OPT_STARTTLS.CHECK_REPLY
> free(): invalid pointer
> libnbd: debug: nbd1: nbd_connect_command: transition:
NEWSTYLE.OPT_STARTTLS.CHECK_REPLY -> NEWSTYLE.OPT_STARTTLS.TLS_HANDSHAKE_READ
> libnbd: debug: nbd1: nbd_connect_command: transition:
NEWSTYLE.OPT_STARTTLS.TLS_HANDSHAKE_READ -> DEAD
> libnbd: debug: nbd1: nbd_connect_command: leave:
error="nbd_connect_command: gnutls_handshake: Error in the pull function.
(-1/1)"
> 
> That libc message about invalid free() is scary; I'm not yet sure
> whether it is a bug in opensuse-leap's gnutls package or something
> we're doing wrong in libnbd.
I had a look into this.  Unfortunately I only have OpenSUSE Tumbleweed
available.  It doesn't fail for me in Tumbleweed.  (It also doesn't
fail in the CI pipeline for Tumbleweed.)

So I guess this problem is somehow specific to nbdkit or gnutls in
OpenSUSE 15.3.

We can probably ignore this failure, under the assumption it is fixed
upstream.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW