Libguestfs - Jun 2022 - [PATCH virt-v2v 0/3] tests: Add a phony Fedora image for testing

On Thu, Jun 09, 2022 at 10:02:54AM +0200, Laszlo Ersek
wrote:
> On 06/08/22 18:48, Richard W.M. Jones wrote:
> > When we split virt-v2v from libguestfs many moons ago, I copied the
> > test-data/ subdirectory over.  I didn't modify it much, and it
> > contains much test data that is irrelevant to virt-v2v.  (This change
> > does _not_ clean up any of that ...)  However we did use the phony
> > Windows image (test-data/phony-guests/windows.img) to do a semblance
> > of testing Windows conversions, or as much as can be done without
> > having the proprietary operating system itself around.
> > 
> > We never used any of the Linux images, and in fact (before this
> > change) they could not be used.
> 
> Ah, indeed; for the LUKS-on-LV stuff, I synched
> "test-data/phony-guests/make-fedora-img.pl" from libguestfs and
> guestfs-tools (commits 8f2bbc3d50d8 and 27da4b0c4991), but didn't touch
> virt-v2v's copy. There was no need, and even prior differences existed.
> 
> ... Indeed, libguestfs commit 0b223a287711 ("test-data: Replace
> deprecated luks_open with cryptsetup_open.", 2021-05-27) had not been
> ported to virt-v2v's copy.
It probably makes sense to backport these commits if they apply
easily.  Can you do that?  I don't think they will conflict with this
series, but would allow us to test the luks-on-lv case additionally.

Rich.
> > They simply don't appear close enough
> > to a real guest to work with virt-v2v.  In particular they lack
> > installed kernels, modules, bootloader config and the program needed
> > to rebuild the initramfs.
> > 
> > This change fixes the Fedora image(s) so they can be used for testing,
> > and adds conversion of those to the testsuite.
> > 
> > I already pushed the first commit in this series since it was a big
> > binary blob update to the phony Fedora RPM database that was not
> > reviewable:
> > 
> >
https://github.com/libguestfs/virt-v2v/commit/0d1b2ec1b733db1ca0bebf2e4a9e8d5fd7db7f93
> > 
> > Rich.
> > 
> > 
> 
> Thanks
> Laszlo
-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
nbdkit - Flexible, fast NBD server with plugins
https://gitlab.com/nbdkit/nbdkit

On 06/09/22 10:11, Richard W.M. Jones wrote:
> On Thu, Jun 09, 2022 at 10:02:54AM +0200, Laszlo Ersek wrote:
>> On 06/08/22 18:48, Richard W.M. Jones wrote:
>>> When we split virt-v2v from libguestfs many moons ago, I copied the
>>> test-data/ subdirectory over.  I didn't modify it much, and it
>>> contains much test data that is irrelevant to virt-v2v.  (This
change
>>> does _not_ clean up any of that ...)  However we did use the phony
>>> Windows image (test-data/phony-guests/windows.img) to do a
semblance
>>> of testing Windows conversions, or as much as can be done without
>>> having the proprietary operating system itself around.
>>>
>>> We never used any of the Linux images, and in fact (before this
>>> change) they could not be used.
>>
>> Ah, indeed; for the LUKS-on-LV stuff, I synched
>> "test-data/phony-guests/make-fedora-img.pl" from libguestfs
and
>> guestfs-tools (commits 8f2bbc3d50d8 and 27da4b0c4991), but didn't
touch
>> virt-v2v's copy. There was no need, and even prior differences
existed.
>>
>> ... Indeed, libguestfs commit 0b223a287711 ("test-data: Replace
>> deprecated luks_open with cryptsetup_open.", 2021-05-27) had not
been
>> ported to virt-v2v's copy.
> 
> It probably makes sense to backport these commits if they apply
> easily.  Can you do that?  I don't think they will conflict with this
> series, but would allow us to test the luks-on-lv case additionally.
I'm marking this for later in my mailbox.

Thanks
Laszlo

On 06/09/22 10:11, Richard W.M. Jones wrote:
> On Thu, Jun 09, 2022 at 10:02:54AM +0200, Laszlo Ersek wrote:
>> On 06/08/22 18:48, Richard W.M. Jones wrote:
>>> When we split virt-v2v from libguestfs many moons ago, I copied the
>>> test-data/ subdirectory over.  I didn't modify it much, and it
>>> contains much test data that is irrelevant to virt-v2v.  (This
change
>>> does _not_ clean up any of that ...)  However we did use the phony
>>> Windows image (test-data/phony-guests/windows.img) to do a
semblance
>>> of testing Windows conversions, or as much as can be done without
>>> having the proprietary operating system itself around.
>>>
>>> We never used any of the Linux images, and in fact (before this
>>> change) they could not be used.
>>
>> Ah, indeed; for the LUKS-on-LV stuff, I synched
>> "test-data/phony-guests/make-fedora-img.pl" from libguestfs
and
>> guestfs-tools (commits 8f2bbc3d50d8 and 27da4b0c4991), but didn't
touch
>> virt-v2v's copy. There was no need, and even prior differences
existed.
>>
>> ... Indeed, libguestfs commit 0b223a287711 ("test-data: Replace
>> deprecated luks_open with cryptsetup_open.", 2021-05-27) had not
been
>> ported to virt-v2v's copy.
> 
> It probably makes sense to backport these commits if they apply
> easily.  Can you do that?  I don't think they will conflict with this
> series, but would allow us to test the luks-on-lv case additionally.
Subject: [v2v PATCH 0/3] add LUKS-on-LVM test
Message-Id: <20220614112709.12210-1-lersek at redhat.com>

https://listman.redhat.com/archives/libguestfs/2022-June/029231.html

Thanks
Laszlo