Richard W.M. Jones
2021-Apr-22 21:08 UTC
[Libguestfs] [PATCH libnbd v2 6/6] examples: copy-libev.c: Add progress
I'm pretty relaxed about you making changes to this example as you wish, and althouh I didn't review them in detail it all looks good, so ACK. I wonder though if the example is now too complicated(!) Perhaps it'd be good to add a second, very basic example using libev? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org
Nir Soffer
2021-Apr-22 23:48 UTC
[Libguestfs] [PATCH libnbd v2 6/6] examples: copy-libev.c: Add progress
On Fri, Apr 23, 2021 at 12:09 AM Richard W.M. Jones <rjones at redhat.com> wrote:> > > I'm pretty relaxed about you making changes to this example as you > wish, and althouh I didn't review them in detail it all looks good, so ACK. > > I wonder though if the example is now too complicated(!) Perhaps it'd > be good to add a second, very basic example using libev?This is certainly too complicated, because this example is also an experiment, trying to implement the core of nbdcopy with libev. I can try to add a basic example, or maybe something like a tutorial that adds functionality one step at a time? Maybe something like: http://libmill.org/tutorial.html Nir