Hans de Goede
2022-Jul-12 19:39 UTC
[Nouveau] [PATCH v2 27/29] ACPI: video: Drop Clevo/TUXEDO NL5xRU and NL5xNU acpi_backlight=native quirks
acpi_backlight=native is the default for these, but as the comment
explains the quirk was still necessary because even briefly registering
the acpi_video0 backlight; and then unregistering it once the native
driver showed up, was leading to issues.
After the "ACPI: video: Make backlight class device registration
a separate step" patch from earlier in this patch-series, we no
longer briefly register the acpi_video0 backlight on systems where
the native driver should be used.
So this is no longer an issue an the quirks are no longer needed.
Cc: Werner Sembach <wse at tuxedocomputers.com>
Signed-off-by: Hans de Goede <hdegoede at redhat.com>
---
drivers/acpi/video_detect.c | 75 -------------------------------------
1 file changed, 75 deletions(-)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 2a4d376a703e..4b9395d1bda7 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -599,81 +599,6 @@ static const struct dmi_system_id video_detect_dmi_table[]
= {
DMI_MATCH(DMI_BOARD_NAME, "N250P"),
},
},
- /*
- * Clevo NL5xRU and NL5xNU/TUXEDO Aura 15 Gen1 and Gen2 have both a
- * working native and video interface. However the default detection
- * mechanism first registers the video interface before unregistering
- * it again and switching to the native interface during boot. This
- * results in a dangling SBIOS request for backlight change for some
- * reason, causing the backlight to switch to ~2% once per boot on the
- * first power cord connect or disconnect event. Setting the native
- * interface explicitly circumvents this buggy behaviour, by avoiding
- * the unregistering process.
- */
- {
- .callback = video_detect_force_native,
- .ident = "Clevo NL5xRU",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
- DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),
- },
- },
- {
- .callback = video_detect_force_native,
- .ident = "Clevo NL5xRU",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "SchenkerTechnologiesGmbH"),
- DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),
- },
- },
- {
- .callback = video_detect_force_native,
- .ident = "Clevo NL5xRU",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Notebook"),
- DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),
- },
- },
- {
- .callback = video_detect_force_native,
- .ident = "Clevo NL5xRU",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
- DMI_MATCH(DMI_BOARD_NAME, "AURA1501"),
- },
- },
- {
- .callback = video_detect_force_native,
- .ident = "Clevo NL5xRU",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
- DMI_MATCH(DMI_BOARD_NAME, "EDUBOOK1502"),
- },
- },
- {
- .callback = video_detect_force_native,
- .ident = "Clevo NL5xNU",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
- DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"),
- },
- },
- {
- .callback = video_detect_force_native,
- .ident = "Clevo NL5xNU",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "SchenkerTechnologiesGmbH"),
- DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"),
- },
- },
- {
- .callback = video_detect_force_native,
- .ident = "Clevo NL5xNU",
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Notebook"),
- DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"),
- },
- },
/*
* Desktops which falsely report a backlight and which our heuristics
--
2.36.0
Werner Sembach
2022-Jul-13 17:15 UTC
[Nouveau] [PATCH v2 27/29] ACPI: video: Drop Clevo/TUXEDO NL5xRU and NL5xNU acpi_backlight=native quirks
Hi, On 7/12/22 21:39, Hans de Goede wrote:> acpi_backlight=native is the default for these, but as the comment > explains the quirk was still necessary because even briefly registering > the acpi_video0 backlight; and then unregistering it once the native > driver showed up, was leading to issues. > > After the "ACPI: video: Make backlight class device registration > a separate step" patch from earlier in this patch-series, we no > longer briefly register the acpi_video0 backlight on systems where > the native driver should be used. > > So this is no longer an issue an the quirks are no longer needed. > > Cc: Werner Sembach <wse at tuxedocomputers.com> > Signed-off-by: Hans de Goede <hdegoede at redhat.com>Tested and can confirm: The quirks are no longer needed with this Patchset. Tested-by: Werner Sembach <wse at tuxedocomputers.com> Kind Regards, Werner Sembach> --- > drivers/acpi/video_detect.c | 75 ------------------------------------- > 1 file changed, 75 deletions(-) > > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > index 2a4d376a703e..4b9395d1bda7 100644 > --- a/drivers/acpi/video_detect.c > +++ b/drivers/acpi/video_detect.c > @@ -599,81 +599,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = { > DMI_MATCH(DMI_BOARD_NAME, "N250P"), > }, > }, > - /* > - * Clevo NL5xRU and NL5xNU/TUXEDO Aura 15 Gen1 and Gen2 have both a > - * working native and video interface. However the default detection > - * mechanism first registers the video interface before unregistering > - * it again and switching to the native interface during boot. This > - * results in a dangling SBIOS request for backlight change for some > - * reason, causing the backlight to switch to ~2% once per boot on the > - * first power cord connect or disconnect event. Setting the native > - * interface explicitly circumvents this buggy behaviour, by avoiding > - * the unregistering process. > - */ > - { > - .callback = video_detect_force_native, > - .ident = "Clevo NL5xRU", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), > - }, > - }, > - { > - .callback = video_detect_force_native, > - .ident = "Clevo NL5xRU", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "SchenkerTechnologiesGmbH"), > - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), > - }, > - }, > - { > - .callback = video_detect_force_native, > - .ident = "Clevo NL5xRU", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "Notebook"), > - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), > - }, > - }, > - { > - .callback = video_detect_force_native, > - .ident = "Clevo NL5xRU", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > - DMI_MATCH(DMI_BOARD_NAME, "AURA1501"), > - }, > - }, > - { > - .callback = video_detect_force_native, > - .ident = "Clevo NL5xRU", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > - DMI_MATCH(DMI_BOARD_NAME, "EDUBOOK1502"), > - }, > - }, > - { > - .callback = video_detect_force_native, > - .ident = "Clevo NL5xNU", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), > - }, > - }, > - { > - .callback = video_detect_force_native, > - .ident = "Clevo NL5xNU", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "SchenkerTechnologiesGmbH"), > - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), > - }, > - }, > - { > - .callback = video_detect_force_native, > - .ident = "Clevo NL5xNU", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "Notebook"), > - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), > - }, > - }, > > /* > * Desktops which falsely report a backlight and which our heuristics
Limonciello, Mario
2022-Jul-13 17:21 UTC
[Nouveau] [PATCH v2 27/29] ACPI: video: Drop Clevo/TUXEDO NL5xRU and NL5xNU acpi_backlight=native quirks
[Public]> -----Original Message----- > From: Werner Sembach <wse at tuxedocomputers.com> > Sent: Wednesday, July 13, 2022 12:08 > To: Hans de Goede <hdegoede at redhat.com>; Ben Skeggs > <bskeggs at redhat.com>; Karol Herbst <kherbst at redhat.com>; Lyude > <lyude at redhat.com>; Daniel Dadap <ddadap at nvidia.com>; Maarten > Lankhorst <maarten.lankhorst at linux.intel.com>; Maxime Ripard > <mripard at kernel.org>; Thomas Zimmermann <tzimmermann at suse.de>; > Jani Nikula <jani.nikula at linux.intel.com>; Joonas Lahtinen > <joonas.lahtinen at linux.intel.com>; Rodrigo Vivi <rodrigo.vivi at intel.com>; > Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>; Deucher, Alexander > <Alexander.Deucher at amd.com>; Koenig, Christian > <Christian.Koenig at amd.com>; Pan at vger.kernel.org; Pan, Xinhui > <Xinhui.Pan at amd.com>; Rafael J . Wysocki <rafael at kernel.org>; Mika > Westerberg <mika.westerberg at linux.intel.com>; Lukas Wunner > <lukas at wunner.de>; Mark Gross <markgross at kernel.org>; Andy > Shevchenko <andy at kernel.org> > Cc: nouveau at lists.freedesktop.org; Daniel Vetter <daniel at ffwll.ch>; David > Airlie <airlied at linux.ie>; intel-gfx <intel-gfx at lists.freedesktop.org>; dri- > devel at lists.freedesktop.org; amd-gfx at lists.freedesktop.org; Len Brown > <lenb at kernel.org>; linux-acpi at vger.kernel.org; platform-driver- > x86 at vger.kernel.org > Subject: Re: [PATCH v2 27/29] ACPI: video: Drop Clevo/TUXEDO NL5xRU and > NL5xNU acpi_backlight=native quirks > > Hi, > > On 7/12/22 21:39, Hans de Goede wrote: > > acpi_backlight=native is the default for these, but as the comment > > explains the quirk was still necessary because even briefly registering > > the acpi_video0 backlight; and then unregistering it once the native > > driver showed up, was leading to issues. > > > > After the "ACPI: video: Make backlight class device registration > > a separate step" patch from earlier in this patch-series, we no > > longer briefly register the acpi_video0 backlight on systems where > > the native driver should be used. > > > > So this is no longer an issue an the quirks are no longer needed. > > > > Cc: Werner Sembach <wse at tuxedocomputers.com> > > Signed-off-by: Hans de Goede <hdegoede at redhat.com> > > Tested and can confirm: The quirks are no longer needed with this Patchset. > > Tested-by: Werner Sembach <wse at tuxedocomputers.com>Probably should include this link tag in this commit too then as it fixes the Tong Fang systems too. Link: https://bugzilla.kernel.org/show_bug.cgi?id=215683> > Kind Regards, > > Werner Sembach > > > --- > > drivers/acpi/video_detect.c | 75 ------------------------------------- > > 1 file changed, 75 deletions(-) > > > > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > > index 2a4d376a703e..4b9395d1bda7 100644 > > --- a/drivers/acpi/video_detect.c > > +++ b/drivers/acpi/video_detect.c > > @@ -599,81 +599,6 @@ static const struct dmi_system_id > video_detect_dmi_table[] = { > > DMI_MATCH(DMI_BOARD_NAME, "N250P"), > > }, > > }, > > - /* > > - * Clevo NL5xRU and NL5xNU/TUXEDO Aura 15 Gen1 and Gen2 have > both a > > - * working native and video interface. However the default detection > > - * mechanism first registers the video interface before unregistering > > - * it again and switching to the native interface during boot. This > > - * results in a dangling SBIOS request for backlight change for some > > - * reason, causing the backlight to switch to ~2% once per boot on > the > > - * first power cord connect or disconnect event. Setting the native > > - * interface explicitly circumvents this buggy behaviour, by avoiding > > - * the unregistering process. > > - */ > > - { > > - .callback = video_detect_force_native, > > - .ident = "Clevo NL5xRU", > > - .matches = { > > - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > > - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), > > - }, > > - }, > > - { > > - .callback = video_detect_force_native, > > - .ident = "Clevo NL5xRU", > > - .matches = { > > - DMI_MATCH(DMI_SYS_VENDOR, > "SchenkerTechnologiesGmbH"), > > - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), > > - }, > > - }, > > - { > > - .callback = video_detect_force_native, > > - .ident = "Clevo NL5xRU", > > - .matches = { > > - DMI_MATCH(DMI_SYS_VENDOR, "Notebook"), > > - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"), > > - }, > > - }, > > - { > > - .callback = video_detect_force_native, > > - .ident = "Clevo NL5xRU", > > - .matches = { > > - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > > - DMI_MATCH(DMI_BOARD_NAME, "AURA1501"), > > - }, > > - }, > > - { > > - .callback = video_detect_force_native, > > - .ident = "Clevo NL5xRU", > > - .matches = { > > - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > > - DMI_MATCH(DMI_BOARD_NAME, "EDUBOOK1502"), > > - }, > > - }, > > - { > > - .callback = video_detect_force_native, > > - .ident = "Clevo NL5xNU", > > - .matches = { > > - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"), > > - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), > > - }, > > - }, > > - { > > - .callback = video_detect_force_native, > > - .ident = "Clevo NL5xNU", > > - .matches = { > > - DMI_MATCH(DMI_SYS_VENDOR, > "SchenkerTechnologiesGmbH"), > > - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), > > - }, > > - }, > > - { > > - .callback = video_detect_force_native, > > - .ident = "Clevo NL5xNU", > > - .matches = { > > - DMI_MATCH(DMI_SYS_VENDOR, "Notebook"), > > - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"), > > - }, > > - }, > > > > /* > > * Desktops which falsely report a backlight and which our heuristics