Nouveau - Feb 2021 - [PATCH 0/9] Add support for SVM atomics in Nouveau

On 2/9/21 5:37 AM, Daniel Vetter wrote:
> On Tue, Feb 9, 2021 at 1:57 PM Alistair Popple <apopple at
nvidia.com> wrote:
>>
>> On Tuesday, 9 February 2021 9:27:05 PM AEDT Daniel Vetter wrote:
>>>>
>>>> Recent changes to pin_user_pages() prevent the creation of
pinned pages in
>>>> ZONE_MOVABLE. This series allows pinned pages to be created in
>> ZONE_MOVABLE
>>>> as attempts to migrate may fail which would be fatal to
userspace.
>>>>
>>>> In this case migration of the pinned page is unnecessary as the
page can
>> be
>>>> unpinned at anytime by having the driver revoke atomic
permission as it
>>>> does for the migrate_to_ram() callback. However a method of
calling this
>>>> when memory needs to be moved has yet to be resolved so any
discussion is
>>>> welcome.
>>>
>>> Why do we need to pin for gpu atomics? You still have the callback
for
>>> cpu faults, so you
>>> can move the page as needed, and hence a long-term pin sounds like
the
>>> wrong approach.
>>
>> Technically a real long term unmoveable pin isn't required, because
as you say
>> the page can be moved as needed at any time. However I needed some way
of
>> stopping the CPU page from being freed once the userspace mappings for
it had
>> been removed. Obviously I could have just used get_page() but from the
>> perspective of page migration the result is much the same as a pin - a
page
>> which can't be moved because of the extra refcount.
> 
> long term pin vs short term page reference aren't fully fleshed out.
> But the rule more or less is:
> - short term page reference: _must_ get released in finite time for
> migration and other things, either because you have a callback, or
> because it's just for direct I/O, which will complete. This means
> short term pins will delay migration, but not foul it complete

GPU atomic operations to sysmem are hard to categorize, because because
application
programmers could easily write programs that do a long series of atomic
operations.
Such a program would be a little weird, but it's hard to rule out.

> 
> - long term pin: the page cannot be moved, all migration must fail.
> Also this will have an impact on COW behaviour for fork (but not sure
> where those patches are, John Hubbard will know).

That would be Jason's commit 57efa1fe59576 ("mm/gup: prevent gup_fast
from racing
with COW during fork"), which is in linux-next 20201216.

> 
> So I think for your use case here you want a) short term page
> reference to make sure it doesn't disappear plus b) callback to make
> sure migrate isn't blocked.
> 
> Breaking ZONE_MOVEABLE with either allowing long term pins or failing
> migrations because you don't release your short term page reference
> isn't good.
> 
>> The normal solution of registering an MMU notifier to unpin the page
when it
>> needs to be moved also doesn't work as the CPU page tables now
point to the
>> device-private page and hence the migration code won't call any
invalidate
>> notifiers for the CPU page.
> 
> Yeah you need some other callback for migration on the page directly.
> it's a bit awkward since there is one already for struct
> address_space, but that's own by the address_space/page cache, not
> HMM. So I think we need something else, maybe something for each
> ZONE_DEVICE?
> 
This direction sounds at least...possible. Using MMU notifiers instead of pins
is definitely appealing. I'm not quite clear on the callback idea above, but
overall it seems like taking advantage of the ZONE_DEVICE tracking of pages
(without having to put anything additional in each struct page), could work.

Additional notes or ideas here are definitely welcome.



thanks,
-- 
John Hubbard
NVIDIA

On Tue, Feb 09, 2021 at 12:53:27PM -0800, John Hubbard
wrote:
> On 2/9/21 5:37 AM, Daniel Vetter wrote:
> > On Tue, Feb 9, 2021 at 1:57 PM Alistair Popple <apopple at
nvidia.com> wrote:
> > > 
> > > On Tuesday, 9 February 2021 9:27:05 PM AEDT Daniel Vetter wrote:
> > > > > 
> > > > > Recent changes to pin_user_pages() prevent the creation
of pinned pages in
> > > > > ZONE_MOVABLE. This series allows pinned pages to be
created in
> > > ZONE_MOVABLE
> > > > > as attempts to migrate may fail which would be fatal to
userspace.
> > > > > 
> > > > > In this case migration of the pinned page is
unnecessary as the page can
> > > be
> > > > > unpinned at anytime by having the driver revoke atomic
permission as it
> > > > > does for the migrate_to_ram() callback. However a
method of calling this
> > > > > when memory needs to be moved has yet to be resolved so
any discussion is
> > > > > welcome.
> > > > 
> > > > Why do we need to pin for gpu atomics? You still have the
callback for
> > > > cpu faults, so you
> > > > can move the page as needed, and hence a long-term pin
sounds like the
> > > > wrong approach.
> > > 
> > > Technically a real long term unmoveable pin isn't required,
because as you say
> > > the page can be moved as needed at any time. However I needed
some way of
> > > stopping the CPU page from being freed once the userspace
mappings for it had
> > > been removed. Obviously I could have just used get_page() but
from the
> > > perspective of page migration the result is much the same as a
pin - a page
> > > which can't be moved because of the extra refcount.
> > 
> > long term pin vs short term page reference aren't fully fleshed
out.
> > But the rule more or less is:
> > - short term page reference: _must_ get released in finite time for
> > migration and other things, either because you have a callback, or
> > because it's just for direct I/O, which will complete. This means
> > short term pins will delay migration, but not foul it complete
> 
> 
> GPU atomic operations to sysmem are hard to categorize, because because
application
> programmers could easily write programs that do a long series of atomic
operations.
> Such a program would be a little weird, but it's hard to rule out.
Yeah, but we can forcefully break this whenever we feel like by revoking
the page, moving it, and then reinstating the gpu pte again and let it
continue.

If that's no possible then what we need here instead is an mlock() type of
thing I think.
> > - long term pin: the page cannot be moved, all migration must fail.
> > Also this will have an impact on COW behaviour for fork (but not sure
> > where those patches are, John Hubbard will know).
> 
> 
> That would be Jason's commit 57efa1fe59576 ("mm/gup: prevent
gup_fast from racing
> with COW during fork"), which is in linux-next 20201216.
Nice, thanks for the pointer.
> 
> 
> > 
> > So I think for your use case here you want a) short term page
> > reference to make sure it doesn't disappear plus b) callback to
make
> > sure migrate isn't blocked.
> > 
> > Breaking ZONE_MOVEABLE with either allowing long term pins or failing
> > migrations because you don't release your short term page
reference
> > isn't good.
> > 
> > > The normal solution of registering an MMU notifier to unpin the
page when it
> > > needs to be moved also doesn't work as the CPU page tables
now point to the
> > > device-private page and hence the migration code won't call
any invalidate
> > > notifiers for the CPU page.
> > 
> > Yeah you need some other callback for migration on the page directly.
> > it's a bit awkward since there is one already for struct
> > address_space, but that's own by the address_space/page cache, not
> > HMM. So I think we need something else, maybe something for each
> > ZONE_DEVICE?
> > 
> 
> This direction sounds at least...possible. Using MMU notifiers instead of
pins
> is definitely appealing. I'm not quite clear on the callback idea
above, but
> overall it seems like taking advantage of the ZONE_DEVICE tracking of pages
> (without having to put anything additional in each struct page), could
work.
> 
> Additional notes or ideas here are definitely welcome.
Well I don't have ideas for the details tbh, just from the little I
learned about how this all fits together pretending to be a pin while
pretending to not be a pin just gets us back to the mess we're trying to
solve with gup vs pup cleanup. And given that the pin_user_pages rollout
hasn't even completed yet it's maybe way to early to already toss it out
again.

I think overall we should try really hard to not mix up things between
memory that's pinned and memory that can be moved. Because retroactively
trying to fix things up just because it was easier to get a feature going
that way is very, very hard. And I think we've demonstrated countless
times that "ah we just fix this with pinning, it doesn't happen often,
no
one will notice" always comes back to bite us later on :-)

Like just looking ahead, 1GB pages are a thing, we will have to support
that, migrate_page is the only way to get there, and statistically just a
1/256th chance of encountering a pinned page guarantees we'll never
assemble a giant page.

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

On Tue, Feb 09, 2021 at 12:53:27PM -0800, John Hubbard wrote:
> This direction sounds at least...possible. Using MMU notifiers instead of
pins
> is definitely appealing. I'm not quite clear on the callback idea
above, but
> overall it seems like taking advantage of the ZONE_DEVICE tracking of pages
> (without having to put anything additional in each struct page), could
work.
It isn't the ZONE_DEVICE page that needs to be tracked.

Really what you want to do here is leave the CPU page in the VMA and
the page tables where it started and deny CPU access to the page. Then
all the proper machinery will continue to work.

IMHO "migration" is the wrong idea if the data isn't actually
moving.

Jason