Nouveau - Jan 2021 - [PATCH 00/29] [Set 15] Finally rid W=1 warnings from GPU!

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.

Lee Jones (29):
  drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural
  drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation
    problems
  drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu'
member
  drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and
    remove others
  drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg'
  drm/gma500/mmu: Actually return an error if one occurs
  drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's
'diff'
    param
  drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function
    param descriptions
  drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another
  drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member
    'manager'
  drm/gma500/psb_intel_sdvo: Demote kernel-doc abuses
  drm/gma500/psb_irq: Demote kernel-doc abuse
  drm/drm_dp_helper: Fix spelling issue and add missing description for
    'enable_frl_ready_hpd'
  drm/gma500/cdv_intel_crt: Demote kernel-doc abuse in
    'cdv_intel_crt_detect_hotplug()'s header
  drm/gma500/cdv_intel_display: Demote kernel-doc abuse in
    'cdv_intel_panel_fitter_pipe()'s header
  drm/gma500/cdv_intel_lvds: Demote unworthy headers to standard blocks
    and fix another
  drm/gma500/cdv_intel_dp: Demote one unworthy header fix another
  drm/gma500/oaktrail_lvds_i2c: Remove unused variables 'tmp'
  drm/gma500/oaktrail_lvds: Demote one documentation header fix another
  drm/gma500/oaktrail_crtc: Demote unworthy kernel-doc headers
  drm/gma500/mdfld_dsi_output: Demote a couple of kernel-doc formatting
    abuses
  drm/gma500/mdfld_intel_display: Demote three kernel-doc formatting
    abuses
  drm/drm_agpsupport: Strip out obviously wrong descriptions and demote
    to standard headers
  drm/i915/gvt/handlers: Remove kernel-doc formatting from
    non-kernel-doc header
  drm/nouveau/nouveau_ioc32: File headers are not good candidates for
    kernel-doc
  drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void
    function
  drm/nouveau/nouveau_bios: Remove unused variable 'pdev' from
    'nouveau_bios_init()'
  drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment
    block
  drm/vmwgfx/ttm_object: Reorder header to immediately precede its
    struct

 drivers/gpu/drm/drm_agpsupport.c             | 46 +++++---------------
 drivers/gpu/drm/drm_dp_helper.c              |  3 +-
 drivers/gpu/drm/gma500/cdv_intel_crt.c       |  2 +-
 drivers/gpu/drm/gma500/cdv_intel_display.c   |  2 +-
 drivers/gpu/drm/gma500/cdv_intel_dp.c        |  4 +-
 drivers/gpu/drm/gma500/cdv_intel_lvds.c      |  7 +--
 drivers/gpu/drm/gma500/mdfld_dsi_output.c    |  4 +-
 drivers/gpu/drm/gma500/mdfld_intel_display.c |  6 +--
 drivers/gpu/drm/gma500/mmu.c                 |  2 +-
 drivers/gpu/drm/gma500/oaktrail_crtc.c       |  6 +--
 drivers/gpu/drm/gma500/oaktrail_lvds.c       |  3 +-
 drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c   |  8 ++--
 drivers/gpu/drm/gma500/psb_intel_sdvo.c      |  6 +--
 drivers/gpu/drm/gma500/psb_irq.c             |  3 +-
 drivers/gpu/drm/i915/gvt/handlers.c          |  2 +-
 drivers/gpu/drm/nouveau/nouveau_bios.c       |  2 -
 drivers/gpu/drm/nouveau/nouveau_ioc32.c      |  4 +-
 drivers/gpu/drm/nouveau/nouveau_svm.c        |  5 +--
 drivers/gpu/drm/vmwgfx/ttm_object.c          | 25 ++++++-----
 drivers/gpu/drm/vmwgfx/vmwgfx_binding.c      |  9 ++--
 drivers/gpu/drm/vmwgfx/vmwgfx_blit.c         |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c       |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c      |  3 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_msg.c          |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_so.c           |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_thp.c          |  1 +
 drivers/gpu/drm/vmwgfx/vmwgfx_validation.c   |  5 ++-
 27 files changed, 74 insertions(+), 90 deletions(-)

Cc: Ben Skeggs <bskeggs at redhat.com>
Cc: "Christian K?nig" <christian.koenig at amd.com>
Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: Dave Airlie <airlied at redhat.com>
Cc: David Airlie <airlied at linux.ie>
Cc: dri-devel at lists.freedesktop.org
Cc: Eddie Dong <eddie.dong at intel.com>
Cc: Eric Anholt <eric at anholt.net>
Cc: Faith <faith at valinux.com>
Cc: Gareth Hughes <gareth at valinux.com>
Cc: intel-gfx at lists.freedesktop.org
Cc: intel-gvt-dev at lists.freedesktop.org
Cc: Jackie Li <yaodong.li at intel.com>
Cc: Jani Nikula <jani.nikula at linux.intel.com>
Cc: Jan Safrata <jan.nikitenko at gmail.com>
Cc: Jesse Barnes <jesse.barnes at intel.com>
Cc: jim liu <jim.liu at intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Cc: Keith Packard <keithp at keithp.com>
Cc: Kevin Tian <kevin.tian at intel.com>
Cc: linaro-mm-sig at lists.linaro.org
Cc: linux-media at vger.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Cc: Maxime Ripard <mripard at kernel.org>
Cc: Min He <min.he at intel.com>
Cc: Niu Bing <bing.niu at intel.com>
Cc: nouveau at lists.freedesktop.org
Cc: Patrik Jakobsson <patrik.r.jakobsson at gmail.com>
Cc: Pei Zhang <pei.zhang at intel.com>
Cc: Ping Gao <ping.a.gao at intel.com>
Cc: Rob Clark <rob.clark at linaro.org>
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: Roland Scheidegger <sroland at vmware.com>
Cc: Sumit Semwal <sumit.semwal at linaro.org>
Cc: Thomas Zimmermann <tzimmermann at suse.de>
Cc: Tina Zhang <tina.zhang at intel.com>
Cc: VMware Graphics <linux-graphics-maintainer at vmware.com>
Cc: Zack Rusin <zackr at vmware.com>
Cc: Zhenyu Wang <zhenyuw at linux.intel.com>
Cc: Zhi Wang <zhi.a.wang at intel.com>
Cc: Zhiyuan Lv <zhiyuan.lv at intel.com>
-- 
2.25.1

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand  * file
mga_ioc32.c

Cc: Ben Skeggs <bskeggs at redhat.com>
Cc: David Airlie <airlied at linux.ie>
Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: dri-devel at lists.freedesktop.org
Cc: nouveau at lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones at linaro.org>
---
 drivers/gpu/drm/nouveau/nouveau_ioc32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_ioc32.c
b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
index adf01ca9e035d..8ddf9b2325a42 100644
--- a/drivers/gpu/drm/nouveau/nouveau_ioc32.c
+++ b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
@@ -1,4 +1,4 @@
-/**
+/*
  * \file mga_ioc32.c
  *
  * 32-bit ioctl compatibility routines for the MGA DRM.
-- 
2.25.1

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/nouveau/nouveau_svm.c: In function ?nouveau_pfns_map?:
 drivers/gpu/drm/nouveau/nouveau_svm.c:810:6: warning: variable ?ret? set but
not used [-Wunused-but-set-variable]

Cc: Ben Skeggs <bskeggs at redhat.com>
Cc: David Airlie <airlied at linux.ie>
Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: dri-devel at lists.freedesktop.org
Cc: nouveau at lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones at linaro.org>
---
 drivers/gpu/drm/nouveau/nouveau_svm.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c
b/drivers/gpu/drm/nouveau/nouveau_svm.c
index 4f69e4c3dafde..84c5bf53fe967 100644
--- a/drivers/gpu/drm/nouveau/nouveau_svm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
@@ -807,7 +807,6 @@ nouveau_pfns_map(struct nouveau_svmm *svmm, struct mm_struct
*mm,
 		 unsigned long addr, u64 *pfns, unsigned long npages)
 {
 	struct nouveau_pfnmap_args *args = nouveau_pfns_to_args(pfns);
-	int ret;
 
 	args->p.addr = addr;
 	args->p.size = npages << PAGE_SHIFT;
@@ -815,8 +814,8 @@ nouveau_pfns_map(struct nouveau_svmm *svmm, struct mm_struct
*mm,
 	mutex_lock(&svmm->mutex);
 
 	svmm->vmm->vmm.object.client->super = true;
-	ret = nvif_object_ioctl(&svmm->vmm->vmm.object, args, sizeof(*args)
+
-				npages * sizeof(args->p.phys[0]), NULL);
+	nvif_object_ioctl(&svmm->vmm->vmm.object, args, sizeof(*args) +
+			  npages * sizeof(args->p.phys[0]), NULL);
 	svmm->vmm->vmm.object.client->super = false;
 
 	mutex_unlock(&svmm->mutex);
-- 
2.25.1

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/nouveau/nouveau_bios.c: In function ?nouveau_bios_init?:
 drivers/gpu/drm/nouveau/nouveau_bios.c:2086:18: warning: variable ?pdev? set
but not used [-Wunused-but-set-variable]

Cc: Ben Skeggs <bskeggs at redhat.com>
Cc: David Airlie <airlied at linux.ie>
Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: dri-devel at lists.freedesktop.org
Cc: nouveau at lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones at linaro.org>
---
 drivers/gpu/drm/nouveau/nouveau_bios.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c
b/drivers/gpu/drm/nouveau/nouveau_bios.c
index 7cc683b8dc7a6..e8c445eb11004 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bios.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
@@ -2083,13 +2083,11 @@ nouveau_bios_init(struct drm_device *dev)
 {
 	struct nouveau_drm *drm = nouveau_drm(dev);
 	struct nvbios *bios = &drm->vbios;
-	struct pci_dev *pdev;
 	int ret;
 
 	/* only relevant for PCI devices */
 	if (!dev_is_pci(dev->dev))
 		return 0;
-	pdev = to_pci_dev(dev->dev);
 
 	if (!NVInitVBIOS(dev))
 		return -ENODEV;
-- 
2.25.1

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or
member 'filp' not described in 'nouveau_compat_ioctl'
 drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or
member 'cmd' not described in 'nouveau_compat_ioctl'
 drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or
member 'arg' not described in 'nouveau_compat_ioctl'

Cc: Ben Skeggs <bskeggs at redhat.com>
Cc: David Airlie <airlied at linux.ie>
Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: dri-devel at lists.freedesktop.org
Cc: nouveau at lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones at linaro.org>
---
 drivers/gpu/drm/nouveau/nouveau_ioc32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_ioc32.c
b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
index 8ddf9b2325a42..2af3615c5205c 100644
--- a/drivers/gpu/drm/nouveau/nouveau_ioc32.c
+++ b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
@@ -38,7 +38,7 @@
 
 #include "nouveau_ioctl.h"
 
-/**
+/*
  * Called whenever a 32-bit process running under a 64-bit kernel
  * performs an ioctl on /dev/dri/card<n>.
  *
-- 
2.25.1

> On Jan 15, 2021, at 13:15, Lee Jones <lee.jones at linaro.org> wrote:
> 
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
> 
> Last set!  All clean after this for; Arm, Arm64, PPC, MIPS and x86.
Thanks! For all the vmwgfx bits:
Reviewed-by: Zack Rusin <zackr at vmware.com>

z