Ovirt devel - Apr 2008 - [Patch] hardware pool/vm resource pool model redesign

This patch refactors the Hardware Pool and VM Resource Pool models. The 
OrgPool/NetworkMap/HostCollection subclasses of HardwarePool are removed 
entirely -- the HardwarePool hierarchy is once again completely 
flexible. You can have a single host pool or a deep hierarchy. VM 
Library has  been renamed to VM Resource Pool. At a model level, 
Hardware Pools and VM Resource Pools now inherit from a common 
(abstract) Pool class -- but this is not exposed in the UI.

In addition to the simpler (and more flexible) Hardware Pool hierarchy, 
the other main focus for this change is to allow a hierarchy of VM 
Resource Pools. The model now supports this, although the views do not 
(yet) allow the creation of nested VM Resource Pools. In addition, the 
quota/resource usage calculations do not yet deal with nested VM Pools.

Anyway, here's the (somewhat large) patch...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pool-model-redesign.patch
Type: text/x-patch
Size: 209648 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/ovirt-devel/attachments/20080414/5017104f/attachment.bin>

On Mon, Apr 14, 2008 at 11:47:58AM -0400, Scott Seago
wrote:
> This patch refactors the Hardware Pool and VM Resource Pool models. The 
> OrgPool/NetworkMap/HostCollection subclasses of HardwarePool are removed 
> entirely -- the HardwarePool hierarchy is once again completely flexible. 
> You can have a single host pool or a deep hierarchy. VM Library has  been 
> renamed to VM Resource Pool. At a model level, Hardware Pools and VM 
> Resource Pools now inherit from a common (abstract) Pool class -- but this 
> is not exposed in the UI.
>
> In addition to the simpler (and more flexible) Hardware Pool hierarchy, the
> other main focus for this change is to allow a hierarchy of VM Resource 
> Pools. The model now supports this, although the views do not (yet) allow 
> the creation of nested VM Resource Pools. In addition, the quota/resource 
> usage calculations do not yet deal with nested VM Pools.
>
> Anyway, here's the (somewhat large) patch...
Yikes, that's huge!

ACK based on your assurance that it works and the knowledge that we'll
need more cleanup as we go along.

One question: What is the indentation standard for ruby/rails code? I
notice you're using 2 spaces, is that normal?

Thanks,
--Hugh