Ovirt devel - Apr 2008 - [PATCH] Error out early if tftpboot exists.

Doh, patch is attached. :)

    Ian

On Thu, 10 Apr 2008 10:46:32 -0700
Ian Main <imain at redhat.com> wrote:
> 
> This simple patch just adds a warning if tftpboot already exists before
doing all the work to create a pxe boot image.  I hadn't noticed the error a
few times as it gets lost in the noise after all the other output it generates.
> 
> Signed-off-by: Ian Main <imain at redhat.com>
> 
>     Ian
> 
> _______________________________________________
> Ovirt-devel mailing list
> Ovirt-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/ovirt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ovirt_pxe.diff
Type: text/x-patch
Size: 495 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/ovirt-devel/attachments/20080410/475f3036/attachment.bin>

Ian Main wrote:
> Ian Main <imain at redhat.com> wrote:
> 
>> This simple patch just adds a warning if tftpboot already exists before
doing all the work to create a pxe boot image.  I hadn't noticed the error a
few times as it gets lost in the noise after all the other output it generates.
It's good to warn before doing all of the work to create the liveCD, so

ACK

Chris Lalancette

Ian Main <imain at redhat.com> wrote:
>> This simple patch just adds a warning if tftpboot already exists before
doing all the work to create a pxe boot image.  I hadn't noticed the error a
few times as it gets lost in the noise after all the other output it generates.
Hi Ian,

Good idea!

If you put that code in the definition of the create_iso function,
users of ovirt-cd.sh, ovirt-flash.sh, and ovirt-flash-static.sh scripts
will benefit, too.
> diff --git a/ovirt-host-creator/ovirt-pxe.sh
b/ovirt-host-creator/ovirt-pxe.sh
> index 8db83bf..022eec9 100755
> --- a/ovirt-host-creator/ovirt-pxe.sh
> +++ b/ovirt-host-creator/ovirt-pxe.sh
> @@ -28,6 +28,12 @@ else
>      exit 1
>  fi
>
> +if [ -e tftpboot ]; then
> +    echo "tftboot/ directory already exists!  Cowardly not
overwriting."
> +    echo "Please rename or delete old version prior to running this
script."
> +    exit 1
> +fi
> +
>  ISO=`create_iso $ISO` || exit 1
>
>  /usr/bin/livecd-iso-to-pxeboot $ISO